Add GitHub annotations for lint #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 21dfb66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
reviewed
Oct 23, 2021
samchungy
changed the title
72636c
changed the title
72636c
reviewed
Oct 25, 2021
72636c
reviewed
Oct 25, 2021
72636c
reviewed
Oct 25, 2021
72636c
reviewed
Oct 25, 2021
src/cli/lint/external.ts
Outdated
| const tools = [ | ||
| ...(eslint.ok ? [] : ['ESLint']), | ||
| ...(prettier.ok ? [] : ['Prettier']), | ||
| ...(tscOk ? [] : ['tsc']), | ||
| ]; | ||
|
|
||
| const summary = `${tools.join(', ')} found issues that require triage.`; | ||
| await createAnnotations(eslint, prettier, tscOk, tscOutputStream, summary); |
There was a problem hiding this comment.
This is for a separate PR, but any thoughts on error handling for annotations? I'm thinking that we should log and continue, rather than failing the command.
There was a problem hiding this comment.
Yeah I was thinking it should log a warning/error - we shouldn't fail the whole test if we simply fail to report
…nto github-lint-annotations
72636c
added a commit
that referenced
this pull request
Oct 26, 2021
Moves the Buildkite annotation refactoring logic out of #625. This will enable us to add different types of annotations and aid in writing unit tests without cluttering the external file. Co-authored-by: Ryan Ling <ryan@outlook.com.au>
72636c
approved these changes
Nov 5, 2021
Co-authored-by: Ryan Ling <ryan@outlook.com.au>
Co-authored-by: Ryan Ling <ryan@outlook.com.au>
Co-authored-by: Ryan Ling <ryan@outlook.com.au>
Co-authored-by: Ryan Ling <ryan@outlook.com.au>
Co-authored-by: Ryan Ling <ryan@outlook.com.au>
Co-authored-by: Ryan Ling <ryan@outlook.com.au>
…nto github-lint-annotations
Co-authored-by: Ryan Ling <ryan@outlook.com.au>
…nto github-lint-annotations
thank you!
Merged
This was referenced Nov 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
Changes:
Screenshots
Status View
Check Run Page View
Files Changed View