Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Serverless params #752

Merged
merged 5 commits into from
Jan 31, 2022
Merged

Use new Serverless params #752

merged 5 commits into from
Jan 31, 2022

Conversation

samchungy
Copy link
Contributor

@samchungy samchungy commented Jan 31, 2022

Use the fancy smancy new params feature. Produces a much cleaner template 馃拵

https://www.serverless.com/framework/docs/guides/parameters

default didn't have to be used but I thought it was a good example of how it can be used.

I guess overall custom should be used more for plugins.

@samchungy samchungy requested a review from a team as a code owner January 31, 2022 07:52
@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2022

馃 Changeset detected

Latest commit: 6d4858d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@samchungy samchungy requested a review from 72636c January 31, 2022 08:01
Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憦 thank you!

template/lambda-sqs-worker/serverless.yml Outdated Show resolved Hide resolved
.changeset/gorgeous-apricots-cross.md Outdated Show resolved Hide resolved
samchungy and others added 2 commits January 31, 2022 22:50
@72636c 72636c merged commit cb157ad into master Jan 31, 2022
@72636c 72636c deleted the serverless-params branch January 31, 2022 12:37
@github-actions github-actions bot mentioned this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants