Time out Buildkite test steps after 10 minutes #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our projects should aim for a shorter duration for testing and linting. Taking longer than 10 minutes usually indicates a command or request has hung and will indefinitely hog the build agent, so we define a timeout.
🦋 Changeset detectedLatest commit: 1089115 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Could we add an auto retry for timeout failures? |
|
@samchungy have you observed many transient timeouts? If so, that makes sense and I'll add 👍 |
|
Hmm not really, haven't had too many issues of late |
|
👌 I'd lean towards keeping this as-is then, we can always revisit in future. The most common issue I've seen is agent resource exhaustion, which is probably made worse by an automatic retry and better resolved by beefing up the instances. |
samchungy
approved these changes
Apr 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our projects should aim for a shorter duration for testing and linting. Taking longer than 10 minutes usually indicates a command or request has hung and will indefinitely hog the build agent, so we define a timeout.