Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to arm64 architecture #873

Merged
merged 15 commits into from
Jun 22, 2022
Merged

feat: move to arm64 architecture #873

merged 15 commits into from
Jun 22, 2022

Conversation

samchungy
Copy link
Contributor

Gantry now has support for arm64. We can pretty much move our builds to arm64.

Todo: Bump up gantry version once the hotfix lands.

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2022

🦋 Changeset detected

Latest commit: fd45c10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -17,7 +17,7 @@ RUN yarn build

###

FROM gcr.io/distroless/nodejs:16 AS runtime
FROM gcr.io/distroless/nodejs:16-arm64 AS runtime
Copy link
Contributor Author

@samchungy samchungy May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if FROM --platform=linux/arm64 works here. I'll have to test

@72636c
Copy link
Member

72636c commented May 24, 2022

One complication with early adoption here is that existing teams will be using Intel build agents. We'd have to figure out how to best communicate that they should provision a Graviton cluster for their new project.

@samchungy
Copy link
Contributor Author

samchungy commented May 24, 2022

One complication with early adoption here is that existing teams will be using Intel build agents. We'd have to figure out how to best communicate that they should provision a Graviton cluster for their new project.

yeah I noticed gantry had some sections on this actually

https://gantry.ssod.skinfra.xyz/docs/v1/reference/using-arm.html

@72636c
Copy link
Member

72636c commented May 24, 2022

One option may be to scrap the queue templating and just inline a bunch of documentation/links/TODOs in our .buildkite/pipeline.yml template files

{
name: 'devBuildkiteQueueName',
message: 'Dev Buildkite queue',
initial: 'my-team-aws-account-dev:cicd',
validate: (value) => /^.+:.+$/.test(value),
},
{
name: 'prodBuildkiteQueueName',
message: 'Prod Buildkite queue',
initial: 'my-team-aws-account-prod:cicd',
validate: (value) => /^.+:.+$/.test(value),
},

@72636c 72636c mentioned this pull request May 25, 2022
1 task
@samchungy
Copy link
Contributor Author

Our buildAgents only support x86 for the GET_GITHUB_TOKEN step for now. Will wait til support is added:

https://seekchat.slack.com/archives/C01J8F3LELB/p1653619527077269?thread_ts=1653617669.275119&cid=C01J8F3LELB

@samchungy samchungy added the dino:snooze Snooze in Review Dino label May 27, 2022
@72636c 72636c removed the dino:snooze Snooze in Review Dino label Jun 22, 2022
@72636c 72636c marked this pull request as ready for review June 22, 2022 06:30
@72636c 72636c requested review from a team as code owners June 22, 2022 06:30
@72636c 72636c enabled auto-merge (squash) June 22, 2022 10:12
@72636c 72636c merged commit 2e4addb into master Jun 22, 2022
@72636c 72636c deleted the arm64 branch June 22, 2022 10:16
@seek-oss-ci seek-oss-ci mentioned this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants