-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move to arm64 architecture #873
Conversation
🦋 Changeset detectedLatest commit: fd45c10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
template/express-rest-api/Dockerfile
Outdated
@@ -17,7 +17,7 @@ RUN yarn build | |||
|
|||
### | |||
|
|||
FROM gcr.io/distroless/nodejs:16 AS runtime | |||
FROM gcr.io/distroless/nodejs:16-arm64 AS runtime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if FROM --platform=linux/arm64
works here. I'll have to test
One complication with early adoption here is that existing teams will be using Intel build agents. We'd have to figure out how to best communicate that they should provision a Graviton cluster for their new project. |
yeah I noticed gantry had some sections on this actually https://gantry.ssod.skinfra.xyz/docs/v1/reference/using-arm.html |
One option may be to scrap the queue templating and just inline a bunch of documentation/links/TODOs in our skuba/template/koa-rest-api/skuba.template.js Lines 13 to 24 in 034fe46
|
Our buildAgents only support x86 for the |
Gantry now has support for arm64. We can pretty much move our builds to arm64.
Todo: Bump up gantry version once the hotfix lands.