Remove Unnecessary Serverless Permission #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2a1ab7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
samchungy
changed the title
72636c
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Good catch. This was a copy+paste from our internal guidance for workers to perform their own in-process re-queuing and DLQing to avoid throttling, though without the actual logic to do so because we haven't open sourced any helper package to achieve this yet.
This has been partially superseded by batch failure reporting, though the "immediate DLQ" case still stands:
https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html#services-sqs-batchfailurereporting
Merged
72636c
pushed a commit
that referenced
this pull request
Sep 10, 2022
* Remove unnecessary permission * Create sharp-ads-clean.md * Update sharp-ads-clean.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This perm is only needed if we configure asynchronous invocation and use the
onErrorconfiguration but SQS is a synchronous invocation and SQS handles the dead-lettering itself.