make linter ignore cdk.out directory #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 52521a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
72636c
reviewed
Aug 15, 2022
template/base/_.prettierignore
Outdated
| @@ -14,4 +14,5 @@ node_modules*/ | |||
| /.gantry/**/*.yml | |||
| gantry*.yaml | |||
| gantry*.yml | |||
| cdk.out*/ | |||
There was a problem hiding this comment.
- Can you avoid smushing this together with the Gantry ignores? It doesn't not seem related and is probably more at home alongside the first block with
node_modulesand such. - Is the asterisk necessary?
72636c
approved these changes
Aug 22, 2022
Merged
72636c
added a commit
that referenced
this pull request
Aug 30, 2022
This is similar to #940. We were already gitignoring this directory.
72636c
added a commit
that referenced
this pull request
Aug 30, 2022
This is similar to #940. We were already gitignoring this directory.
72636c
added a commit
that referenced
this pull request
Sep 10, 2022
Co-authored-by: Ryan Ling <ryan@outlook.com.au>
72636c
added a commit
that referenced
this pull request
Sep 10, 2022
This is similar to #940. We were already gitignoring this directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ignore cdk.out directory linting rule.
yarn formatoryarn lintwill probably trigger node heap out of memory issues otherwise.