Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #962

Merged
merged 5 commits into from
Sep 6, 2022
Merged

Fix CI #962

merged 5 commits into from
Sep 6, 2022

Conversation

72636c
Copy link
Member

@72636c 72636c commented Sep 6, 2022

In both the clean install and continuous integration senses. Gets us past this issue:

#961 (comment)

Gets us past this issue:

#961 (comment)

In the longer term I'd like to purge our `package-json` dependency as
that family of packages has incessant churn for little upside.
@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2022

🦋 Changeset detected

Latest commit: f0892e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skuba Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@72636c 72636c marked this pull request as ready for review September 6, 2022 12:16
@72636c 72636c requested review from a team as code owners September 6, 2022 12:16
@72636c 72636c merged commit 43b9ebd into master Sep 6, 2022
@72636c 72636c deleted the fix-ci branch September 6, 2022 12:37
@seek-oss-ci seek-oss-ci mentioned this pull request Sep 6, 2022
72636c added a commit that referenced this pull request Sep 10, 2022
72636c added a commit that referenced this pull request Sep 20, 2022
I unwittingly broke this in #962 and unfortunately we have no coverage
of the undercooked `configure` command currently. That rushed hack
doesn't make any sense in hindsight as it tries to fetch the "latest"
version from the local disk, which isn't going to tell you if local is
outdated.
72636c added a commit that referenced this pull request Sep 20, 2022
I unwittingly broke this in #962 and unfortunately we have no coverage
of the undercooked `configure` command currently. That rushed hack
doesn't make any sense in hindsight as it tries to fetch the "latest"
version from the local disk, which isn't going to tell you if local is
outdated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants