Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove filescoping from babel-plugin, Add transform integration APIs #827

Merged
merged 28 commits into from Sep 21, 2022
Merged

Remove filescoping from babel-plugin, Add transform integration APIs #827

merged 28 commits into from Sep 21, 2022

Conversation

mattcompiles
Copy link
Contributor

This PR does the following things:

  • Removes filescope appending from babel plugin
  • Adds a new package (@vanilla-extract/jest) to be used instead of using the babel plugin
  • Adds new transform and transformSync APIs that handle filescoping and automatic debug Ids
  • Updates all the existing integrations to use the new transform APIs internally
    • This results in OOTB automatic debug Id support in all integrations

@mattcompiles mattcompiles requested a review from a team September 14, 2022 05:15
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022 •
edited

🦋 Changeset detected

Latest commit: c70aaaf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@vanilla-extract/esbuild-plugin Minor
@vanilla-extract/vite-plugin Minor
@vanilla-extract/rollup-plugin Minor
@vanilla-extract/integration Major
@vanilla-extract/webpack-plugin Minor
@vanilla-extract/next-plugin Minor
@vanilla-extract/jest-transform Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

askoufis
askoufis approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mattcompiles mattcompiles merged commit 9cfb9a1 into master Sep 21, 2022
@mattcompiles mattcompiles deleted the rm-filescope-babel branch September 21, 2022 00:56
@seek-oss-ci seek-oss-ci mentioned this pull request Sep 21, 2022
Merged
jgresham pushed a commit to jgresham/vanilla-extract that referenced this pull request Sep 28, 2022
@mattcompiles @jgresham
Remove filescoping from babel-plugin, Add transform integration APIs (v…
a4668c2 
…anilla-extract-css#827)
@zbauman3 zbauman3 mentioned this pull request Nov 30, 2022
Closed
2 tasks
@mrm007 mrm007 mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdalgleish markdalgleish markdalgleish left review comments

@jahredhope jahredhope jahredhope left review comments

@askoufis askoufis askoufis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattcompiles @markdalgleish @askoufis @jahredhope