Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto debugId for styleVariants #956

Merged
merged 13 commits into from Jan 16, 2023
Merged

Fix auto debugId for styleVariants #956

merged 13 commits into from Jan 16, 2023

Conversation

mrm007
Copy link
Contributor

@mrm007 mrm007 commented Jan 4, 2023

Looks like a bug slipped through in #827:

const four = styleVariants({
red: {
color: 'red'
}
}, 'myDebugValue', \\"four\\");"

This fix is also needed in #955 where layer() can have up to 2 arguments:

const lib = layer();
const utils = layer({ parent: lib });
const reset = layer({ parent: lib }, 'my-reset');
const other = layer('my-other'); // don't add a debug id

@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2023

🦋 Changeset detected

Latest commit: 1c6d3ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vanilla-extract/babel-plugin-debug-ids Patch
@vanilla-extract/integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/css/src/vars.ts Outdated Show resolved Hide resolved
Base automatically changed from jest-29 to master January 9, 2023 21:38
@mrm007 mrm007 mentioned this pull request Jan 10, 2023
4 tasks
Copy link
Contributor

@jahredhope jahredhope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Nice work.

@michaeltaranto michaeltaranto merged commit eea3c7d into master Jan 16, 2023
@michaeltaranto michaeltaranto deleted the fix-debug-id branch January 16, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants