Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global key support #170

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Global key support #170

merged 1 commit into from
Oct 30, 2023

Conversation

jasoncheng-jora
Copy link
Collaborator

  • Vocab push: push custom key to Phrase
  • Vocab pull: use translation of custom key
  • Add Vocab CLI feature flag --error-on-no-global-key-translation
  • Doc: Update README

@jasoncheng-jora jasoncheng-jora requested a review from a team as a code owner October 24, 2023 05:53
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: b7dddbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@vocab/phrase Minor
@vocab/core Minor
@vocab/cli Minor
@vocab/react Patch
@vocab/types Patch
@vocab/webpack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@rstacruz rstacruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it to the @askoufis @jahredhope for the full review, but this looks good so far 👍 Thanks for the comprehensive update to the tests and docs as well.

Copy link
Collaborator

@adriankencana adriankencana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍🏻

Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've got some feedback around naming and release notes/docs, but overall the PR looks good.

packages/core/src/types.ts Outdated Show resolved Hide resolved
packages/phrase/src/config.ts Outdated Show resolved Hide resolved
packages/core/src/config.ts Outdated Show resolved Hide resolved
packages/phrase/src/push-translations.ts Outdated Show resolved Hide resolved
packages/phrase/src/pull-translations.test.ts Outdated Show resolved Hide resolved
.changeset/lemon-mails-battle.md Outdated Show resolved Hide resolved
.changeset/many-apricots-try.md Outdated Show resolved Hide resolved
.changeset/nasty-seahorses-confess.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jasoncheng-jora
Copy link
Collaborator Author

jasoncheng-jora commented Oct 25, 2023

@askoufis Thanks for the review.

packages/phrase/src/push-translations.ts Outdated Show resolved Hide resolved
.changeset/many-apricots-try.md Outdated Show resolved Hide resolved
@askoufis
Copy link
Contributor

askoufis commented Oct 27, 2023

FYI I published some snapshots of the changes on this branch here if you want to try them in an app. Just updating regular dependencies might not update all versions of the package, so you'll probably want to use resolutions/overrides as some packages depend on eachother.

EDIT: I have tested this feature out and it works how I would expect.

@jasoncheng-jora
Copy link
Collaborator Author

@askoufis Awesome, thanks.

@jasoncheng-jora
Copy link
Collaborator Author

@askoufis Tested in Echo web app and it works correctly.

@jasoncheng-jora jasoncheng-jora merged commit 161d698 into master Oct 30, 2023
4 checks passed
@jasoncheng-jora jasoncheng-jora deleted the global-key-support branch October 30, 2023 02:27
@seek-oss-ci seek-oss-ci mentioned this pull request Oct 30, 2023
jahredhope pushed a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants