Convert the simple fixture's vocab config to CJS
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
askoufis
changed the title
simple fixture's config to CJSsimple fixture's vocab config to CJS
askoufis
force-pushed
the
cjs-vocab-config-fixture
branch
from
3ee0a23
to
d7f9c71
Compare
mrm007
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #176.
As noted in the comment, ideally we'd just use
resolveConfigSync, but we'd need to pass a custom working directory to it. Alternatively could resolve both config paths explicitly with some try catches, but I think that's worse than this solution.