Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: es-module-lexer ^1.0.0 #217

Merged
merged 4 commits into from
Apr 2, 2024
Merged

fix: es-module-lexer ^1.0.0 #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f212d11
fix: es-module-lexer ^1.0.0
renovate[bot] Mar 31, 2024
5a52243
Add changeset
askoufis Apr 1, 2024
3c6601e
Merge branch 'master' into renovate-es-module-lexer-1.x
askoufis Apr 1, 2024
e0ffaad
Destructure export name
askoufis Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-crews-hear.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@vocab/webpack': patch
---

Update `es-module-lexer` dependency
2 changes: 1 addition & 1 deletion packages/webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@vocab/core": "^1.6.2",
"cjs-module-lexer": "^1.2.2",
"debug": "^4.3.1",
"es-module-lexer": "^0.10.0",
"es-module-lexer": "^1.0.0",
"picocolors": "^1.0.0",
"virtual-resource-loader": "^1.0.1"
},
Expand Down
9 changes: 7 additions & 2 deletions packages/webpack/src/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ function renderLanguageLoaderAsync(
};
}

function findExportNames(source: string, mode: 'cjs'): string[];
function findExportNames(
source: string,
mode: 'esm',
): esModuleLexer.ExportSpecifier[];
function findExportNames(source: string, mode: 'cjs' | 'esm') {
if (mode === 'esm') {
const [, exports] = esModuleLexer.parse(source);
Expand Down Expand Up @@ -126,12 +131,12 @@ export default async function vocabLoader(this: LoaderContext, source: string) {
const esmExports = findExportNames(source, 'esm');
if (esmExports.length > 0) {
const exportName = esmExports[0];
trace(`Found ESM export '${exportName}' in ${this.resourcePath}`);
trace(`Found ESM export '${exportName.n}' in ${this.resourcePath}`);

result = /* ts */ `
import { createLanguage, createTranslationFile } from '@vocab/webpack/${target}';
${translations}
export { translations as ${exportName} };
export { translations as ${exportName.n} };
`;
} else {
// init needs to be called and waited upon
Expand Down
8 changes: 2 additions & 6 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.