Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dropdown bug in guide #573

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

cn1t
Copy link
Member

@cn1t cn1t commented Aug 16, 2023

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Project infrastructure change (like issue templates, etc.)

How Has This Been Tested?

Please check all browsers you have tested on. Please also list any relevant details for your test configuration

  • Chromium Based Browser
  • Mozilla Firefox

Test Configuration:

  • Windows
  • Linux
  • MacOS
  • BSD

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I am a web developer

@cn1t cn1t requested a review from 9glenda August 16, 2023 13:50
@cn1t cn1t self-assigned this Aug 16, 2023
@cn1t cn1t linked an issue Aug 16, 2023 that may be closed by this pull request
@cn1t cn1t marked this pull request as draft August 16, 2023 13:51
@cn1t
Copy link
Member Author

cn1t commented Aug 16, 2023

my sanity is draining

@9glenda 9glenda added this to the 0.4.0 milestone Aug 18, 2023
@cn1t
Copy link
Member Author

cn1t commented Aug 18, 2023

divine interventions are hindering querySelector from working properly

@9glenda
Copy link
Member

9glenda commented Aug 20, 2023

A in dropdown value change listener is still missing but that's not that hard to add

@cn1t
Copy link
Member Author

cn1t commented Aug 20, 2023

image
why do you use an innerhtml here @9glenda

@9glenda
Copy link
Member

9glenda commented Aug 21, 2023

image why do you use an innerhtml here @9glenda

@Niteletsplay
You mean test1? It's the ID/name of the dropdown.

@cn1t
Copy link
Member Author

cn1t commented Aug 21, 2023

image why do you use an innerhtml here @9glenda

@Niteletsplay
You mean test1? It's the ID/name of the dropdown.

Cant you just use an attribute like title="test1"?

@9glenda
Copy link
Member

9glenda commented Aug 21, 2023

image why do you use an innerhtml here @9glenda

@Niteletsplay
You mean test1? It's the ID/name of the dropdown.

Cant you just use an attribute like title="test1"?

I'll change it to do so. Everything you put as HTML will be ignored anyway.

@9glenda
Copy link
Member

9glenda commented Aug 21, 2023

@Niteletsplay you can now simply add an event listener called change.

const d = getDropdown("test1")

d!.addEventListener("change", function() {
  console.log(getValue("test1"));
});

@9glenda
Copy link
Member

9glenda commented Aug 21, 2023

@Niteletsplay should change also be executed on selecting the item already selected and therefore not change of the value?

@cn1t
Copy link
Member Author

cn1t commented Aug 21, 2023

@Niteletsplay should change also be executed on selecting the item already selected and therefore not change of the value?

No, but there shouldnt be a problem if it is

@9glenda
Copy link
Member

9glenda commented Aug 22, 2023

@Niteletsplay now it only has to be implemented in guide

@cn1t
Copy link
Member Author

cn1t commented Aug 22, 2023

Do we use this implementation in the edit view too?

@9glenda 9glenda mentioned this pull request Aug 24, 2023
17 tasks
@9glenda
Copy link
Member

9glenda commented Aug 24, 2023

Dropdowns in edit need to be changed to the new implementation then everything is done

@cn1t cn1t modified the milestones: 0.4.0, 0.5.0 Aug 24, 2023
@9glenda 9glenda closed this Aug 25, 2023
@9glenda 9glenda reopened this Aug 25, 2023
@9glenda
Copy link
Member

9glenda commented Aug 25, 2023

@Niteletsplay don't close this pr

1 similar comment
@9glenda
Copy link
Member

9glenda commented Aug 25, 2023

@Niteletsplay don't close this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WEBSITE BUG] Fix dropdown in guide window
2 participants