Merge pull request #9 from leinher/main

chirpotle: Update flash command to spot missing firemware argument
seemoo-lab · Nov 27, 2023 · 05de650 · 05de650
2 parents 855a628 + 46d0d59
commit 05de650
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/chirpotle.sh b/chirpotle.sh
@@ -439,6 +439,7 @@ function chirpotle_flash {
           exit 0
         ;;
         *)
+          # This is only called if manadatory argument exists. We need to check if firmware value is set after argument parsing.
           if [[ "$FIRMWARE" == "" ]]; then
             FIRMWARE="$1"
             shift
@@ -450,6 +451,11 @@ function chirpotle_flash {
         ;;
     esac
   done
+
+  if [[ "$FIRMWARE" == "" ]]; then
+    echo "No firmware specified. Abort flash." >&2
+    echo "Call chirpotle.sh flash --help for usage information." >&2
+  fi
 
   # Enter virtual environment
   source "$ENVDIR/bin/activate"