New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "clamshell mode" to "sleep on lid close" #1207
Comments
It's @IceStormNG 's idea ;) thing is that checkbox will actually disable sleep on lid close when external monitor + power is connected, and enable it back when either monitor or power is disconnected |
I called it that way, because Apple calls it like this on Macs, which have that feature built-in. This is usually the common term most people refer to when they talk about this behavior (not sleeping on lid close when power + external display is connected). |
Well, for me it's also clear (as i'm a mac user mostly). But I will probably add some kind of tooltip to this checkbox as i have noticed few times already, that not everyone gets what does it mean and do :) |
yea, a tooltip would be cool. I did not realize what it was until I was reading all of the past code release notes earlier today. |
@seerge @IceStormNG sorry for not knowing, i'm not a mac user FWIW, i hate it when lid closed = sleep. It makes moving around with my laptop a chore as i have to always keep it open 🙄 . As for the tooltip i don't know how to explain it better than @seerge 's initial reply. |
@TheBestPessimist @russellmm @IceStormNG I have added tooltip, this should do the thing |
Not sure if the tooltip is as clear as it could be. My confusion is "but i already set it to 'never sleep', so this does nothing?". Would any of these be more clear?
or
|
@TheBestPessimist i have spelled literally what it does. It disables sleep. If it's already set to do nothing - nothing would change for you :) |
I have seen multiple questions on the topic "G-Helper is putting my laptop to sleep on lid close, even though i set it multiple times to do nothing".
And then you had to teach every person about clamshell and what it is.
Could it be renamed to something better (or have a tooltip). My suggestion would be:
but maybe there is a better phrasing.
All in all, i, too, find "Auto Toggle Clamshell Mode" unintuitive.
The text was updated successfully, but these errors were encountered: