Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "clamshell mode" to "sleep on lid close" #1207

Closed
TheBestPessimist opened this issue Aug 28, 2023 · 9 comments
Closed

Rename "clamshell mode" to "sleep on lid close" #1207

TheBestPessimist opened this issue Aug 28, 2023 · 9 comments

Comments

@TheBestPessimist
Copy link

TheBestPessimist commented Aug 28, 2023

I have seen multiple questions on the topic "G-Helper is putting my laptop to sleep on lid close, even though i set it multiple times to do nothing".
And then you had to teach every person about clamshell and what it is.

Could it be renamed to something better (or have a tooltip). My suggestion would be:

Sleep on lid close and internal monitor

but maybe there is a better phrasing.

All in all, i, too, find "Auto Toggle Clamshell Mode" unintuitive.

@seerge
Copy link
Owner

seerge commented Aug 28, 2023

It's @IceStormNG 's idea ;) thing is that checkbox will actually disable sleep on lid close when external monitor + power is connected, and enable it back when either monitor or power is disconnected

@IceStormNG
Copy link
Contributor

I called it that way, because Apple calls it like this on Macs, which have that feature built-in. This is usually the common term most people refer to when they talk about this behavior (not sleeping on lid close when power + external display is connected).
Windows has no such feature, so I made it myself and gave it the same name.

@seerge
Copy link
Owner

seerge commented Aug 28, 2023

Well, for me it's also clear (as i'm a mac user mostly). But I will probably add some kind of tooltip to this checkbox as i have noticed few times already, that not everyone gets what does it mean and do :)

@russellmm
Copy link

yea, a tooltip would be cool. I did not realize what it was until I was reading all of the past code release notes earlier today.

@TheBestPessimist
Copy link
Author

TheBestPessimist commented Aug 29, 2023

@seerge @IceStormNG sorry for not knowing, i'm not a mac user ¯\_(ツ)_/¯.

FWIW, i hate it when lid closed = sleep. It makes moving around with my laptop a chore as i have to always keep it open 🙄 .

As for the tooltip i don't know how to explain it better than @seerge 's initial reply.

@seerge
Copy link
Owner

seerge commented Aug 29, 2023

@TheBestPessimist @russellmm @IceStormNG

I have added tooltip, this should do the thing

GHelper.zip

@seerge seerge closed this as completed Aug 29, 2023
seerge added a commit that referenced this issue Aug 29, 2023
@TheBestPessimist
Copy link
Author

image

Not sure if the tooltip is as clear as it could be. My confusion is "but i already set it to 'never sleep', so this does nothing?".

Would any of these be more clear?

Enable sleep on lid close *except* when plugged in and external monitor is connected
^^^^^^^^^^^^^^^^^^^^^

or

Sleep on lid close. Disable sleep on lid close when plugged in and external monitor is connected
^^^^^^^^^^^^

@TheBestPessimist
Copy link
Author

funny how when editing the markdown, the code is monospaced, but when published, it is not
image

@seerge
Copy link
Owner

seerge commented Aug 29, 2023

@TheBestPessimist i have spelled literally what it does. It disables sleep. If it's already set to do nothing - nothing would change for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants