Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling XG Mobile always put's it in Eco mode #1235

Closed
moritzbeck13 opened this issue Sep 1, 2023 · 30 comments
Closed

Disabling XG Mobile always put's it in Eco mode #1235

moritzbeck13 opened this issue Sep 1, 2023 · 30 comments
Labels
question Further information is requested

Comments

@moritzbeck13
Copy link

moritzbeck13 commented Sep 1, 2023

Describe the bug
Title basically

Clear scenario to Reproduce
Steps to reproduce the behavior:

  1. GHelper is in Standard mode (or Optimized and plugged in)
  2. Enable XG Mobile
  3. whatever
  4. Disable XG Mobile
  5. GHelper is in Eco mode
  6. XG Mobile cannot be actived in Eco mode
  7. Have to return to Standard (or Optimized) mode

Expected behavior
GHelper returns to the previous mode (which currently can only be Standard or Optimized) or at least a mode where the last action (disabling the XG mobile) can be reverted (by activating it) -> idempotence

App Logs
log.txt

Desktop (please complete the following information):

  • OS: Windows 11
  • Laptop model: X13 2023

Asus software

  • Armoury Crate (or it's services installed): no
  • MyASUS installed: no
  • Other Asus services running in background: stopped

Additional context
I only have a iGPU and no onboard dGPU. Not exactly sure what Eco vs. Standard even does then, why the XG Mobile can only be activated from Standard mode (or Optimized when plugged in) and if and how any of this plays into it here.

@seerge
Copy link
Owner

seerge commented Sep 1, 2023

@moritzbeck01 hello, i have checked a log and it looks like it's hardcoded like that in BIOS (G-Helper doesn't set eco mode)

01.09.2023 22:58:54: Eco flag : 0 - app checked current status - ECO WAS OFF
01.09.2023 22:58:54: Mux flag : -65536
01.09.2023 22:59:02: WMI event 190
01.09.2023 22:59:02: WMI event 194
01.09.2023 22:59:05: GPU XGM = 0 : OK - disabling XGM
01.09.2023 22:59:05: WMI event 123
01.09.2023 22:59:05: WMI event 123
01.09.2023 22:59:15: Design Capacity: 75001mWh, Full Charge Capacity: 72870mWh, Health: 0,971587045506059919201077319%
01.09.2023 22:59:20: Eco flag : 1 - app checked current status and ECO is suddenly ON
01.09.2023 22:59:20: Mux flag : -65536

I can add some extra command after disabling XGM, to set dGPU on ... but i'm not sure if I should, as it's clearly asus engineers did that on purpose


P.S. Sorry, I have just read your "additional context", if you don't have dGPU - then i think there is no difference for you Eco or not eco :)) as only purpose of eco - is to disable dGPU, that's it.

Even more - i think this "eco" thing is specific only to your case (when device doesn't have dGPU at all) as others who were testing XGM here , didn't had that "problem"

@seerge seerge added the question Further information is requested label Sep 1, 2023
@seerge
Copy link
Owner

seerge commented Sep 1, 2023

@moritzbeck01 closing as not planned, as there is nothing to fix here :) in your case eco = standard (you see the switch in a first place because app just sees that eco flag exists in bios)

@seerge seerge closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2023
@moritzbeck13
Copy link
Author

moritzbeck13 commented Sep 1, 2023

@seerge Thanks, so changing into what mode it goes is not possible, right? But can you remove the restriction to only enable from Standard mode and allow Eco aswell? Would fix my problem too.

@seerge
Copy link
Owner

seerge commented Sep 3, 2023

@moritzbeck01 what's your specific model name ? you have uploaded only fraction of the log, so it's not there

@seerge
Copy link
Owner

seerge commented Sep 3, 2023

I can only assume it's GV301RA

This build should allow enabling XG Mobile with this model even in eco

GHelper.zip

@seerge seerge reopened this Sep 3, 2023
seerge added a commit that referenced this issue Sep 3, 2023
Hide Backlight OSD if asus OSD is running
seerge added a commit that referenced this issue Sep 3, 2023
@moritzbeck13
Copy link
Author

what's your specific model name ?

GV302XA, but is it not possible to make this model independent?

@seerge
Copy link
Owner

seerge commented Sep 3, 2023

@moritzbeck01 no, cause you device reports a dGPU on/off flag (eco) as existing, so i can't separate it from other devices

Check this build

GHelper.zip

@Wolper321
Copy link

GV302XA is the model without dGPU the same as mine. So check first if you even have the GPU modes in AC. I am almost sure you have no switch and this makes your laptop constantly in eco.

@moritzbeck13
Copy link
Author

@seerge I understand, but what speaks against just removing the limitation in GHelper to enable the XG Mobile from Eco mode for all devices? From what I understand, the XG Mobile is separate from the BIOS flag, so enabling it shouldn't be an issue with either value.

@seerge
Copy link
Owner

seerge commented Sep 4, 2023

@moritzbeck01 because for devices that have dGPU - it has to be in "Standard" mode prior to enabling XGM. At least according to another user who asked about that limitation explicitly :)

#423 (comment)

Does the build i linked here work fine for you ?

@moritzbeck13
Copy link
Author

moritzbeck13 commented Sep 5, 2023

@seerge

Does the build i linked here work fine for you ?

Yes, seems to work.

because for devices that have dGPU - it has to be in "Standard" mode prior to enabling XGM.

Could you then allow changing from Eco mode but also set Standard mode flag in BIOS when enabling XG Mobile? I think even for users with dGPU it would be broken in Optimized mode otherwise.

@seerge
Copy link
Owner

seerge commented Sep 6, 2023

I think its better to not to create a new potential point of failure and do it same as ac does :)

@seerge seerge closed this as completed Sep 6, 2023
@moritzbeck13
Copy link
Author

I think its better to not to create a new potential point of failure

👍

and do it same as ac does :)

But Armory Crate does it exactly that way?

@moritzbeck13
Copy link
Author

@seerge I think the newest update broke something - I cannot disable the XG Mobile anymore.

@seerge
Copy link
Owner

seerge commented Sep 25, 2023

@moritzbeck01 "newest update" is what version? and in what version it still works (can you test it again?)

As i didn't change anything in the app related to xgm at all since this discussion

@moritzbeck13
Copy link
Author

Seems like it's related to something else, it isn't working on any recent older version either. I probably just noticed it now since I tried to disconnect after updating. Enabling works fine though.
log.txt

@moritzbeck13
Copy link
Author

Should I open a new issue for this or is it unrelated to G-Helper? @seerge

@seerge
Copy link
Owner

seerge commented Sep 27, 2023

@moritzbeck01 what do you mean under not being to disable it ? How do you know it's not disabled after ?

In a log disable command seem to go though (with a positive response)

25.09.2023 19:42:41: GPU XGM = 0 : OK

@moritzbeck13
Copy link
Author

@seerge Well my screen connected to it is still on, for starters. Also G-Helper still displays it as connected. It seems to load something and then just silently fail.

@seerge
Copy link
Owner

seerge commented Sep 27, 2023

@moritzbeck01 i see, but since it worked before and then stopped i don't think it's something i can "fix" as the command is the same for all devices

@moritzbeck13
Copy link
Author

Okay, I understand. Is there any starting point to look why this is happening?

@seerge
Copy link
Owner

seerge commented Sep 27, 2023

@moritzbeck01 i don’t know:) try to do hardware reset of a laptop may be?

@Wolper321
Copy link

Okay, I understand. Is there any starting point to look why this is happening?

When I was testing different XGM activation commands I was also unable to disable XGM in Ghelper. Exactly in the way you have described.
I just ended up manually unplugging it and continued with the system warning. With the correct activation command (the special one for 6850M XT), I have never experienced it again.

@moritzbeck13
Copy link
Author

I have a 3080 though. Maybe they changed it in a driver update?

@Wolper321
Copy link

I have a 3080 though. Maybe they changed it in a driver update?

Check in your config if you have "xgm_special": 1. Maybe this messing with your 3080.

@moritzbeck13
Copy link
Author

Check in your config if you have "xgm_special": 1. Maybe this messing with your 3080.

I had to restart before it worked, but that did the trick. Thank you very much! Now I just wonder why this was set. I can't remember doing that...

@seerge
Copy link
Owner

seerge commented Sep 28, 2023

@moritzbeck01 app would set xgm_special flag automatically , but only if it spots a 6850M connected (this is for @Wolper321 's case as 6850M requires special connection command)

if (GpuControl.FullName.Contains("6850M")) AppConfig.Set("xgm_special", 1);

Did you by any chance used 6850M as well (before) ?

@moritzbeck13
Copy link
Author

Not really, but my 3080 was connected to another laptop that uses the 6850M.

@seerge
Copy link
Owner

seerge commented Sep 28, 2023

@moritzbeck01 haha, i don't think it spreads like that.

Anyway unless you have set flag by yourself, it was added by G-Helper cause it has spotted 6850M in the system.

As you see in the code, it's quite explicit check :)

@moritzbeck13
Copy link
Author

Maybe I absent-mindedly changed it when I wanted to do something else, idk :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants