New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling XG Mobile always put's it in Eco mode #1235
Comments
@moritzbeck01 hello, i have checked a log and it looks like it's hardcoded like that in BIOS (G-Helper doesn't set eco mode)
I can add some extra command after disabling XGM, to set dGPU on ... but i'm not sure if I should, as it's clearly asus engineers did that on purpose P.S. Sorry, I have just read your "additional context", if you don't have dGPU - then i think there is no difference for you Eco or not eco :)) as only purpose of eco - is to disable dGPU, that's it. Even more - i think this "eco" thing is specific only to your case (when device doesn't have dGPU at all) as others who were testing XGM here , didn't had that "problem" |
@moritzbeck01 closing as not planned, as there is nothing to fix here :) in your case eco = standard (you see the switch in a first place because app just sees that eco flag exists in bios) |
@seerge Thanks, so changing into what mode it goes is not possible, right? But can you remove the restriction to only enable from Standard mode and allow Eco aswell? Would fix my problem too. |
@moritzbeck01 what's your specific model name ? you have uploaded only fraction of the log, so it's not there |
I can only assume it's GV301RA This build should allow enabling XG Mobile with this model even in eco |
Hide Backlight OSD if asus OSD is running
GV302XA, but is it not possible to make this model independent? |
@moritzbeck01 no, cause you device reports a dGPU on/off flag (eco) as existing, so i can't separate it from other devices Check this build |
GV302XA is the model without dGPU the same as mine. So check first if you even have the GPU modes in AC. I am almost sure you have no switch and this makes your laptop constantly in eco. |
@seerge I understand, but what speaks against just removing the limitation in GHelper to enable the XG Mobile from Eco mode for all devices? From what I understand, the XG Mobile is separate from the BIOS flag, so enabling it shouldn't be an issue with either value. |
@moritzbeck01 because for devices that have dGPU - it has to be in "Standard" mode prior to enabling XGM. At least according to another user who asked about that limitation explicitly :) Does the build i linked here work fine for you ? |
Yes, seems to work.
Could you then allow changing from Eco mode but also set Standard mode flag in BIOS when enabling XG Mobile? I think even for users with dGPU it would be broken in Optimized mode otherwise. |
I think its better to not to create a new potential point of failure and do it same as ac does :) |
👍
But Armory Crate does it exactly that way? |
@seerge I think the newest update broke something - I cannot disable the XG Mobile anymore. |
@moritzbeck01 "newest update" is what version? and in what version it still works (can you test it again?) As i didn't change anything in the app related to xgm at all since this discussion |
Seems like it's related to something else, it isn't working on any recent older version either. I probably just noticed it now since I tried to disconnect after updating. Enabling works fine though. |
Should I open a new issue for this or is it unrelated to G-Helper? @seerge |
@moritzbeck01 what do you mean under not being to disable it ? How do you know it's not disabled after ? In a log disable command seem to go though (with a positive response)
|
@seerge Well my screen connected to it is still on, for starters. Also G-Helper still displays it as connected. It seems to load something and then just silently fail. |
@moritzbeck01 i see, but since it worked before and then stopped i don't think it's something i can "fix" as the command is the same for all devices |
Okay, I understand. Is there any starting point to look why this is happening? |
@moritzbeck01 i don’t know:) try to do hardware reset of a laptop may be? |
When I was testing different XGM activation commands I was also unable to disable XGM in Ghelper. Exactly in the way you have described. |
I have a 3080 though. Maybe they changed it in a driver update? |
Check in your config if you have "xgm_special": 1. Maybe this messing with your 3080. |
I had to restart before it worked, but that did the trick. Thank you very much! Now I just wonder why this was set. I can't remember doing that... |
@moritzbeck01 app would set g-helper/app/HardwareControl.cs Line 270 in 03944dc
Did you by any chance used 6850M as well (before) ? |
Not really, but my 3080 was connected to another laptop that uses the 6850M. |
@moritzbeck01 haha, i don't think it spreads like that. Anyway unless you have set flag by yourself, it was added by G-Helper cause it has spotted 6850M in the system. As you see in the code, it's quite explicit check :) |
Maybe I absent-mindedly changed it when I wanted to do something else, idk :D |
Describe the bug
Title basically
Clear scenario to Reproduce
Steps to reproduce the behavior:
Expected behavior
GHelper returns to the previous mode (which currently can only be Standard or Optimized) or at least a mode where the last action (disabling the XG mobile) can be reverted (by activating it) -> idempotence
App Logs
log.txt
Desktop (please complete the following information):
Asus software
Additional context
I only have a iGPU and no onboard dGPU. Not exactly sure what Eco vs. Standard even does then, why the XG Mobile can only be activated from Standard mode (or Optimized when plugged in) and if and how any of this plays into it here.
The text was updated successfully, but these errors were encountered: