Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mappable button combo for disconnecting XG Mobile #1964

Closed
lawrstay opened this issue Jan 21, 2024 · 8 comments
Closed

Mappable button combo for disconnecting XG Mobile #1964

lawrstay opened this issue Jan 21, 2024 · 8 comments
Labels
question Further information is requested

Comments

@lawrstay
Copy link

Is your feature request related to a problem? Please describe.
Disconnecting XG Mobile connection could have assessibility feature to assist carpal tunnel syndrome users.

Describe the solution you'd like
I'd like to map a keyboard shortcut to allow convenient disconnection of XG Mobile, so that I could map that keyboard shortcut to a controller button, that would allow me to disconnect XGM without using mouse/keyboard when Asus device is docked via XGM.

Additional context
The use case for this is when Rog ALLY or Asus laptop is connected to a TV, and having this feature would allow user to disconnect XGM without turning on the TV , open GHelper window, use mouse to click disconnect. Instead user can just use keyboard shortcut with the TV turned off, and just observe the XGM connector's red light turn white, to know that it's safe to disconnect. Thank you for considering.

@seerge
Copy link
Owner

seerge commented Jan 21, 2024

@lawrstay hello, it's quite exotic requirement.

Since I don't have XGM. Don't you have to also set "GPU mode" switch to Standard prior to toggling XGM on Ally as well? (i know it doesn't really switch any real GPU, but that endpoint exists on Ally and G-Helper shows that buttons cause of that)

@seerge seerge added the question Further information is requested label Jan 21, 2024
@lawrstay
Copy link
Author

lawrstay commented Jan 21, 2024

Thank you Seerge for your response. Yes that's true, if the mappable shortcut could be a toggle, that would be useful for both toggling connect & disconnecting XGM, as GHelper is always running in the taskbar.

For the Ally, I just select XGM directly without needing to switch to standard mode

@seerge
Copy link
Owner

seerge commented Jan 21, 2024

@lawrstay you didn't answer my question:

Does toggling XG Mobile require setting mode to "Standard" in GPU section ? or would it toggle fine even when "Eco" is selected?

@lawrstay
Copy link
Author

Apologies, I edited my response to answer your question after rereading. It would toggle fine even when Eco is selected.

@seerge
Copy link
Owner

seerge commented Jan 21, 2024

@lawrstay try this build, I have added binding below Alt-Tab option in a dropdown

GHelper.zip

seerge added a commit that referenced this issue Jan 21, 2024
@lawrstay
Copy link
Author

Thanks for the quick work on this request.

It works well!

Would it be possible to add an option in Extra section to "disable XG mobile warning" ? Currently the popup still requires a mouse to select yes, making the disconnection not as seamless as the connection.

@seerge
Copy link
Owner

seerge commented Jan 21, 2024

@lawrstay i have removed warning if toggle happens from hotkey

GHelper.zip

@lawrstay
Copy link
Author

Amazing, thank you so much. I'll give this a spin for few days and circle back if I find any issues.

@seerge seerge closed this as completed Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants