Skip to content
This repository has been archived by the owner on Jan 2, 2024. It is now read-only.

Update applyAsMentor method with new fields #245

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

Madhawa97
Copy link
Member

Purpose

The purpose of this PR is to fix #228

Goals

Mentors should be able to update all fields using applyAsMentor endpoint

Approach

Update the src/main/java/org/sefglobal/scholarx/service/ProgramService.java:applyAsMentor method to set the following fields.

  1. category
  2. expertise
  3. institution
  4. position
  5. bio
  6. slots

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@Piumal1999 Piumal1999 changed the title update applyAsMentor method with new fields Update applyAsMentor method with new fields Dec 9, 2021
Copy link
Member

@Piumal1999 Piumal1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thank you @Madhawa97

@Piumal1999 Piumal1999 merged commit 6be6e4c into sef-global:sx-february Dec 9, 2021
@Madhawa97 Madhawa97 deleted the fix-endpoints branch December 9, 2021 16:40
@Madhawa97
Copy link
Member Author

You're welcome @Piumal1999

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mentors should be able to update all fields using applyAsMentor endpoint
2 participants