Create controller API for fellowship #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gravewalker666
commented
May 13, 2020
jayasanka-sack
requested changes
May 14, 2020
backend/src/main/java/org/sefglobal/core/exception/CertificateNotFoundException.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/sefglobal/core/model/Certificate.java
Outdated
Show resolved
Hide resolved
Gravewalker666
force-pushed
the
master
branch
2 times, most recently
from
db2d02b
to
dbf24f3
Compare
jayasanka-sack
requested changes
May 21, 2020
backend/src/main/java/org/sefglobal/core/controller/CertificateController.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/sefglobal/core/service/CertificateService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/sefglobal/core/controller/CertificateController.java
Outdated
Show resolved
Hide resolved
jayasanka-sack
previously approved these changes
May 23, 2020
|
@YohanAvishke Could you please review this? |
backend/src/main/java/org/sefglobal/core/controller/CertificateController.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/sefglobal/core/controller/CertificateController.java
Show resolved
Hide resolved
backend/src/main/java/org/sefglobal/core/model/Certificate.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/sefglobal/core/service/CertificateService.java
Show resolved
Hide resolved
backend/src/main/java/org/sefglobal/core/service/CertificateService.java
Show resolved
Hide resolved
Gravewalker666
force-pushed
the
master
branch
2 times, most recently
from
9c72edf
to
c60b3ec
Compare
backend/src/main/java/org/sefglobal/core/controller/CertificateController.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/sefglobal/core/model/Certificate.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #25
Goals
The goal is to create an API to be functioned as the sef-fellowship certificate generator.
Approach
Created all the necessary files and implemented the API endpoints adhering to the above requirements in the issue.
Checklist
Test environment
Learning