Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Academix APIs to reuse the Entity classes for data transportation #60

Merged
merged 2 commits into from
Jun 28, 2020
Merged

Refactoring Academix APIs to reuse the Entity classes for data transportation #60

merged 2 commits into from
Jun 28, 2020

Conversation

YohanAvishke
Copy link
Member

@YohanAvishke YohanAvishke commented Jun 28, 2020 •
edited
Loading

Purpose

The purpose of this PR is to fix #59 and fix #61

Goals

Resue the Entity classes to transport data to the backend and from the backend

Approach

  1. Added necessary JSON annotation to handle data in Entities
  2. Created duplicated methods that use the modified Entities to transfer data.
  3. Removed Projections and DTO classes

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Test environment

macOS 10.15, JDK 1.8

@YohanAvishke YohanAvishke added enhancement New feature or request academix Issues or improvements related to Academix project labels Jun 28, 2020
@YohanAvishke
Refactor all the APIs to use the Entity models to transport data
01a1203 
All the DTOs and Projections were removed and reused
the Entity classes to transport data to the APIs and
from the APIs.
@YohanAvishke YohanAvishke mentioned this pull request Jun 28, 2020
Closed
jayasanka-sack
jayasanka-sack approved these changes Jun 28, 2020
View reviewed changes
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @YohanAvishke !

@Gravewalker666 Gravewalker666 merged commit 45bc9a5 into sef-global:master Jun 28, 2020
@YohanAvishke YohanAvishke deleted the academix-backend branch June 28, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayasanka-sack jayasanka-sack jayasanka-sack approved these changes

@Gravewalker666 Gravewalker666 Gravewalker666 approved these changes

Assignees
No one assigned
Labels
academix Issues or improvements related to Academix project enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicate api level and service level methods Refactoring Academix APIs to reuse the Entity classes
3 participants
@YohanAvishke @jayasanka-sack @Gravewalker666