Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a component to add subcategories #67

Merged
merged 1 commit into from Jul 15, 2020
Merged

Create a component to add subcategories #67

merged 1 commit into from Jul 15, 2020

Conversation

anjula-sack
Copy link
Member

@anjula-sack anjula-sack commented Jul 7, 2020 •
edited

Purpose

Goals

  • Adding maintain functionalities to admin dashboard to maintain academix

Approach

  • Create a component to add subcategories
  • Edit AddItem component according to the new payload
  • Remove redundant scope from main style.css
    sub

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@anjula-sack anjula-sack force-pushed the academix-admin branch 2 times, most recently from 6c1eed6 to e9f34c9 Compare July 7, 2020 16:37
jayasanka-sack
jayasanka-sack requested changes Jul 8, 2020
View reviewed changes
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anjula-sack.
Please fix the mentioned minor issues

frontend/app/src/scenes/Home/scenes/AddItem/index.tsx Outdated Show resolved Hide resolved
frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx Outdated Show resolved Hide resolved
frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx Outdated Show resolved Hide resolved
frontend/app/src/scenes/Home/styles.css Outdated Show resolved Hide resolved
Gravewalker666
Gravewalker666 previously approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@Gravewalker666 Gravewalker666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @anjula-sack

@anjula-sack anjula-sack added academix Issues or improvements related to Academix project admin-dashboard labels Jul 14, 2020
jayasanka-sack
jayasanka-sack reviewed Jul 15, 2020
View reviewed changes
frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx Outdated
<Spin tip="Loading..." spinning={this.state.isLoading}>
<Form size="large" onFinish={this.onFinish}>
<Title level={3}>Category</Title>
<Text>Select category for the subcategory</Text>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we replace this with "Select a category"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

jayasanka-sack
jayasanka-sack previously approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anjula-sack !

jayasanka-sack
jayasanka-sack approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anjula-sack !

@jayasanka-sack jayasanka-sack merged commit 0182e5b into sef-global:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayasanka-sack jayasanka-sack jayasanka-sack approved these changes

@Gravewalker666 Gravewalker666 Gravewalker666 left review comments

Assignees
No one assigned
Labels
academix Issues or improvements related to Academix project admin-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a component to add subcategories
3 participants
@anjula-sack @jayasanka-sack @Gravewalker666