Create a generic component to update and insert SubCategories #78

anjula-sack · 2020-07-16T03:34:04Z

Purpose

The purpose of this PR is to fix Create a edit component to edit the subcategory #77
Change the status code of PUT method response. #80

Goals

Add editing function to subcategories

Approach

Edit AddSubCategory component to edit subcategory
Change the HTTP response from 202 ACCEPTED to 200 OK

Checklist

This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

jayasanka-sack

Good job @anjula-sack!
I think we can reuse the form too..

frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx

jayasanka-sack

Good work @anjula-sack ,

Consider about the mentioned change requests

frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx

Gravewalker666 · 2020-07-17T15:13:34Z

I think it's better if we could display the SubCategory Id in the edit view, Maybe in a disabled text input or something?
What do you think @jayasanka-sack?

jayasanka-sack

Nice to see that the component has improved a lot!

Added some comments, fix them too. :)

jayasanka-sack · 2020-07-18T07:20:54Z

frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx

    this.state = {
      isLoading: false,
      categories: [],
+      subcategory: null,
+      isComponentEdit: false,


instead of saving a boolean. Store the type which accepts only "add" and "edit"

Also, it shouldn't be a state variable since you don't need to rerender the component when the component type changes. (the type isn't changing time to time)

yes I will change it.

jayasanka-sack · 2020-07-18T07:24:15Z

frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx

+      method = 'post';
+      url = '/core/academix/admin/sub-categories/';
+    } else {
+      statusCode = 202;


This should fix in the backend

so what should I do until then?

you can fix the backend with this PR. It's a single line change

jayasanka-sack · 2020-07-18T07:28:20Z

frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx

+                  {this.state.subcategory != null &&
+                    this.subCategoryForm('Edit Subcategory')}
+                  {this.state.subcategory == null &&
+                    this.subCategoryForm('Add Subcategory')}


I think it's better if you could use a generic string to the button.

What about "Save" ?

jayasanka-sack · 2020-07-18T07:35:07Z

I think it's better if we could display the SubCategory Id in the edit view, Maybe in a disabled text input or something?
What do you think @jayasanka-sack?

Yes, it's good. But according to the use case, the users don't use IDs to identify a subcategory. We use it to programmatically identify it, but a normal user identifies a subcategory by its category's name and the subcategory name.

So I think we don't need to display ids in the UI because it isn't informative data to the user. @YohanAvishke WDYT?

frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx

jayasanka-sack

Nice job @anjula-sack !

Fix the following to improve the component.

frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx

jayasanka-sack · 2020-07-19T12:49:06Z

frontend/app/src/scenes/Home/scenes/UpsertSubCategory/index.tsx

+        );
+      });
+  };
+  render() {


Add a space between functions

jayasanka-sack

Thanks @anjula-sack !

Fixed

anjula-sack force-pushed the edit-subcategory branch from 29be4b5 to c2fad36 Compare July 16, 2020 06:44

anjula-sack marked this pull request as ready for review July 16, 2020 06:56

anjula-sack force-pushed the edit-subcategory branch from c2fad36 to 84e037b Compare July 16, 2020 06:58

jayasanka-sack requested changes Jul 16, 2020

View reviewed changes

frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx Outdated Show resolved Hide resolved

Gimhan-minion added academix Issues or improvements related to Academix project admin-dashboard labels Jul 16, 2020

anjula-sack force-pushed the edit-subcategory branch 4 times, most recently from 7441520 to 64e7f01 Compare July 17, 2020 06:27

Gravewalker666 previously requested changes Jul 17, 2020

View reviewed changes

frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx Outdated Show resolved Hide resolved

anjula-sack force-pushed the edit-subcategory branch 2 times, most recently from 429fa9a to 25b8582 Compare July 17, 2020 10:47

jayasanka-sack requested changes Jul 17, 2020

View reviewed changes

anjula-sack force-pushed the edit-subcategory branch 3 times, most recently from 53df049 to 60eee6e Compare July 18, 2020 05:37

jayasanka-sack requested changes Jul 18, 2020

View reviewed changes

jayasanka-sack reviewed Jul 18, 2020

View reviewed changes

frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx Outdated Show resolved Hide resolved

Gravewalker666 mentioned this pull request Jul 18, 2020

Create a generic component to add and edit categories #81

Merged

6 tasks

anjula-sack force-pushed the edit-subcategory branch from 60eee6e to 6efbf56 Compare July 18, 2020 09:00

anjula-sack requested a review from jayasanka-sack July 18, 2020 11:57

anjula-sack force-pushed the edit-subcategory branch from 6efbf56 to b35671a Compare July 18, 2020 12:45

jayasanka-sack requested changes Jul 18, 2020

View reviewed changes

frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx Outdated Show resolved Hide resolved

frontend/app/src/scenes/Home/scenes/AddSubCategory/index.tsx Outdated Show resolved Hide resolved

anjula-sack force-pushed the edit-subcategory branch 3 times, most recently from 2bbc9b3 to 0b87449 Compare July 18, 2020 16:24

anjula-sack requested a review from jayasanka-sack July 19, 2020 03:31

anjula-sack force-pushed the edit-subcategory branch 4 times, most recently from 76f866a to d93eac8 Compare July 19, 2020 12:20

anjula-sack changed the title ~~Reuse AddSubCategory component to edit subcategories~~ Create a generic component to update and insert SubCategories Jul 19, 2020

anjula-sack force-pushed the edit-subcategory branch from d93eac8 to 3940c79 Compare July 19, 2020 12:33

jayasanka-sack reviewed Jul 19, 2020

View reviewed changes

Create a generic component to update and insert SubCategories

e7c9d44

anjula-sack force-pushed the edit-subcategory branch from 3940c79 to e7c9d44 Compare July 19, 2020 12:55

jayasanka-sack approved these changes Jul 19, 2020

View reviewed changes

jayasanka-sack merged commit 1f6fa13 into sef-global:master Jul 19, 2020

anjula-sack mentioned this pull request Jul 22, 2020

Modify current Add Subcategory component to Edit Subcategories. #79

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a generic component to update and insert SubCategories #78

Create a generic component to update and insert SubCategories #78

anjula-sack commented Jul 16, 2020 •

edited

jayasanka-sack left a comment

jayasanka-sack left a comment

Gravewalker666 commented Jul 17, 2020

jayasanka-sack left a comment

jayasanka-sack Jul 18, 2020

jayasanka-sack Jul 18, 2020

anjula-sack Jul 18, 2020

jayasanka-sack Jul 18, 2020

anjula-sack Jul 18, 2020

jayasanka-sack Jul 18, 2020

anjula-sack Jul 18, 2020

jayasanka-sack Jul 18, 2020

anjula-sack Jul 18, 2020

jayasanka-sack commented Jul 18, 2020 •

edited

jayasanka-sack left a comment

jayasanka-sack Jul 19, 2020

anjula-sack Jul 19, 2020

jayasanka-sack left a comment

Create a generic component to update and insert SubCategories #78

Create a generic component to update and insert SubCategories #78

Conversation

anjula-sack commented Jul 16, 2020 • edited

Purpose

Goals

Approach

Checklist

jayasanka-sack left a comment

Choose a reason for hiding this comment

jayasanka-sack left a comment

Choose a reason for hiding this comment

Gravewalker666 commented Jul 17, 2020

jayasanka-sack left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayasanka-sack commented Jul 18, 2020 • edited

jayasanka-sack left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayasanka-sack left a comment

Choose a reason for hiding this comment

anjula-sack commented Jul 16, 2020 •

edited

jayasanka-sack commented Jul 18, 2020 •

edited