Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a breadcrumb for Items and Subcategories #85

Merged
merged 1 commit into from Jul 23, 2020
Merged

Add a breadcrumb for Items and Subcategories #85

merged 1 commit into from Jul 23, 2020

Conversation

anjula-sack
Copy link
Member

@anjula-sack anjula-sack commented Jul 19, 2020 •
edited

Purpose

Goals

  • Showing page titles

Approach

  • Create a function to fetch selected category details.
  • Create a function to fetch selected Subcategory details.
  • Add breadcrumb and link them to relevant places.
    Kapture 2020-07-20 at 17 53 47

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Gimhan-minion
Gimhan-minion reviewed Jul 19, 2020
View reviewed changes
Copy link
Contributor

@Gimhan-minion Gimhan-minion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to use "/" or ">" instead of "|" to separate the title. WDYT? @jayasanka-sack @Piumal1999

@anjula-sack anjula-sack force-pushed the page-titles branch 2 times, most recently from 35a9130 to 9888517 Compare July 20, 2020 07:26
@anjula-sack anjula-sack changed the title Add page titles for Items and Subcategories Add a breadcrumb for Items and Subcategories Jul 20, 2020
@anjula-sack anjula-sack force-pushed the page-titles branch 5 times, most recently from bba3283 to fe37afd Compare July 20, 2020 12:56
jayasanka-sack
jayasanka-sack requested changes Jul 20, 2020
View reviewed changes
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @anjula-sack !

Added some suggestions.

frontend/app/src/scenes/Home/scenes/Category/index.tsx Outdated Show resolved Hide resolved
frontend/app/src/scenes/Home/scenes/Category/scenes/subcategories/index.tsx Outdated Show resolved Hide resolved
frontend/app/src/scenes/Home/scenes/Category/scenes/subcategories/index.tsx Outdated Show resolved Hide resolved
frontend/app/src/scenes/Home/scenes/Category/scenes/subcategories/index.tsx Outdated Show resolved Hide resolved
frontend/app/src/scenes/Home/scenes/Category/scenes/subcategories/index.tsx Outdated Show resolved Hide resolved
jayasanka-sack
jayasanka-sack approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @anjula-sack !
Nicely done!

@jayasanka-sack jayasanka-sack merged commit 96a31e1 into sef-global:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gimhan-minion Gimhan-minion Gimhan-minion left review comments

@jayasanka-sack jayasanka-sack jayasanka-sack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show page title in categories, subcategories and items
3 participants
@anjula-sack @jayasanka-sack @Gimhan-minion