Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the calendar API to order event list by starting time #27

Merged
merged 1 commit into from Apr 24, 2020

Conversation

Piumal1999
Copy link
Member

Purpose

The purpose of this PR is to fix #26

Goals

Updating the calendar API to order event list by starting time

Approach

Added "orderBy" attribute to the URL.
Note: "orderBy" is only available when querying single events (i.e. the parameter singleEvents is True)

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

N/A

Test environment

IntelliJ IDEA 2019.1.1 (Ultimate Edition)
JRE: 1.8.0_202-release-1483-b44 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o

Learning

N/A

Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Piumal1999 !

Comment on lines 36 to 39
"/events" +
"?orderBy=startTime" +
"&singleEvents=true" +
"&timeMin=" +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a single string it should be a single line. Could you please fix this? :)

oneliveCalendarId +
"/events?orderBy=startTime&singleEvents=true&timeMin=" +
formattedDateTime +

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Piumal1999 !

@jayasanka-sack jayasanka-sack merged commit b0e3c89 into sef-global:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the calendar API to order event list by the starting time
2 participants