Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testimonial section to upspeak page #1039

Merged

Conversation

gajindubandara
Copy link
Collaborator

@gajindubandara gajindubandara commented Jul 22, 2021

Purpose

The purpose of this PR is to fix #1038

Goals

To add a testimonial section to the UpSpeak page

Approach

Added the testimonial section to the UpSpeak page
Did further discussions about the testimonial section in HIVE(https://sef.discourse.group/t/creating-a-new-webpage-for-upspeak/298/6?u=gajindu_bandara)

Screenshots

Screenshot from 2021-07-22 12-29-33

Preview Link

https://pr-1039-sef-site.surge.sh/

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@sef-bot
Copy link
Member

sef-bot commented Jul 22, 2021

This pull request has been mentioned on SEF Hive. There might be relevant details there:

https://sef.discourse.group/t/creating-a-new-webpage-for-upspeak/298/30

Copy link
Member

@Gravewalker666 Gravewalker666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is alright, but there are a bunch of unnecessary indentation changes.
Try to keep only the changes related to the task, if it's hard to undo it's alright, there's no harm in merging this.
Give it a try and let me know. :)

@gajindubandara
Copy link
Collaborator Author

gajindubandara commented Jul 22, 2021

The code is alright, but there are a bunch of unnecessary indentation changes.
Try to keep only the changes related to the task, if it's hard to undo it's alright, there's no harm in merging this.
Give it a try and let me know. :)

I guess the thing is I used the code reformat function in the intel ij to make the new code in the correct order. So it has affected the whole code.

@gajindubandara
Copy link
Collaborator Author

@Gravewalker666 I tried but it seems hard to re-align all the things 😅

Copy link
Member

@Gravewalker666 Gravewalker666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, @gajindubandara I forgot about this PR
I thought I merged it sorry for the delay

@Gravewalker666 Gravewalker666 merged commit 4f614da into sef-global:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Testimonial section to the UpSpeak page
3 participants