Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a script to load videos from youtube API #632

Merged
merged 2 commits into from Mar 29, 2020
Merged

Create a script to load videos from youtube API #632

merged 2 commits into from Mar 29, 2020

Conversation

anjula-sack
Copy link
Member

Purpose

Goals

  • Create a script to load videos from youtube API

Approach

  • Write a script to load items from the url.

Preview Link

https://pr-628-sef-site.surge.sh/onelive/archive

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@anjula-sack anjula-sack requested review from jayasanka-sack and Piumal1999 and removed request for jayasanka-sack March 28, 2020 13:32
src/main/webapp/onelive/archive/index.html Outdated Show resolved Hide resolved
src/main/webapp/onelive/index.html Show resolved Hide resolved
@anjula-sack anjula-sack removed the request for review from Piumal1999 March 29, 2020 02:23
Copy link
Member

@Gravewalker666 Gravewalker666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! @anjula-sack

@Gravewalker666 Gravewalker666 merged commit 3ebc192 into sef-global:one-live Mar 29, 2020
success: function (data) {
//mustache render
let renderedData = Mustache.render(
$('#template-youtube-vidoe').html(), {data: data});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! my fault. I must have missed that when I reviewed the code. Sorry for the mistake.

@jayasanka-sack
Copy link
Member

@anjula-sack @Gravewalker666 Need to do something for long descriptions.

@Gravewalker666
Copy link
Member

@jayasanka-sack Sorry? I didn't get it.

anjula-sack added a commit to anjula-sack/sef-site that referenced this pull request Apr 19, 2020
* Create a script to load videos from youtube API
Piumal1999 pushed a commit that referenced this pull request Apr 19, 2020
* Create a script to load videos from youtube API
Piumal1999 pushed a commit to Piumal1999/sef-site that referenced this pull request Apr 26, 2020
* Create a script to load videos from youtube API
Piumal1999 pushed a commit to Piumal1999/sef-site that referenced this pull request Apr 26, 2020
* Create a script to load videos from youtube API
Piumal1999 pushed a commit to Piumal1999/sef-site that referenced this pull request Apr 28, 2020
* Create a script to load videos from youtube API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants