Load upcoming events on example page #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gravewalker666
requested changes
Apr 9, 2020
src/main/webapp/onelive/index.html
Outdated
| function loadUpcomingEvents() { | ||
| $.ajax({ | ||
| type: 'GET', | ||
| url: 'http://localhost:8080/calendar/onelive', |
There was a problem hiding this comment.
localhost:8080?
Isn't this service up and running?
There was a problem hiding this comment.
Oh yes. I forgot to change it. I'll update
src/main/webapp/onelive/index.html
Outdated
Comment on lines
342
to
343
| payload.items[i].startTime = start.toString().substring(16, 21); | ||
| payload.items[i].endTime = end.toString().substring(16, 21); |
There was a problem hiding this comment.
Try .toLocaleDateString() and .toLocaleTimeString()
There was a problem hiding this comment.
Not necessary but check those methods out.
Rewrite the function using toLocalDateString method and toLocalTimeString method
Gravewalker666
approved these changes
Apr 10, 2020
| } | ||
| }, | ||
| error: function () { | ||
| console.log("Error occurred while loading upcoming events"); |
There was a problem hiding this comment.
Console logs should not be in the code.
|
The preview isn't working |
Comment on lines
+2107
to
+2114
| <a href="" target="_blank"> | ||
| <div class="card card-event shadow shadow-lg--hover mb-1"> | ||
| <div class="card-body"> | ||
| <span class="h5 mr-1 card-event-date">12</span> | ||
| <span class="small text-muted mr-4 text-capitalize">APR, SUN</span> | ||
| <span class="mr-5"> 7.00 - 8.00 pm</span> | ||
| <span class="font-weight-bold ml-1">Energy harvesting in wearable electronics</span> | ||
| </div> |
There was a problem hiding this comment.
Is this a dummy event?
The event in the calendar is not in the suitable format. It was added as full day event. Have to add the events as limited time events |
6 tasks
Piumal1999
added a commit
to Piumal1999/sef-site
that referenced
this pull request
Apr 25, 2020
* Add a link to event card component * Load upcoming events on onelive page * Fix bugs * Add required changes Rewrite the function using toLocalDateString method and toLocalTimeString method * Change ajax get URL
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #648
Goals
Load upcoming events on example page for testing purposes.
Approach
Updated the component to hold a link
Got data in JSON format using Calendar API of sef-data-holder
Used Mustache.js to render
Loaded upcoming events on a duplicate onelive page
Screenshots
Preview Link
https://pr-649-sef-site.surge.sh/onelive/
Checklist
Related PRs
N/A
Test environment
Ubuntu 19.04
Google Chrome
JRE: 1.8.0_202-release-1483-b44 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Learning
N/A