Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alumni section to team.html #740

Merged
merged 1 commit into from Jul 28, 2020
Merged

Add alumni section to team.html #740

merged 1 commit into from Jul 28, 2020

Conversation

Gimhan-minion
Copy link
Contributor

@Gimhan-minion Gimhan-minion commented Jul 12, 2020 •
edited

Purpose

The purpose of this PR is to fix #739

Goals

To add past SEF members to the SEF website.

Approach

  1. Created a new section in team.json file and add all the past members in it.
  2. Uploaded each of their images.
  3. Made changes in team.html as required.

Preview Link

https://pr-740-sef-site.surge.sh/team.html

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

anjula-sack
anjula-sack reviewed Jul 13, 2020
View reviewed changes
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to add LinkedIn links? If we don’t we can remove it? @Gimhan-minion

@Gimhan-minion Gimhan-minion marked this pull request as draft July 19, 2020 14:47
@Gimhan-minion Gimhan-minion marked this pull request as ready for review July 26, 2020 02:24
anjula-sack
anjula-sack previously approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! @Gimhan-minion

Gravewalker666
Gravewalker666 requested changes Jul 26, 2020
View reviewed changes
src/main/webapp/team.html Outdated Show resolved Hide resolved
Piumal1999
Piumal1999 approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@Piumal1999 Piumal1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @Gimhan-minion Thank you

@Gravewalker666 Gravewalker666 merged commit 2d796da into sef-global:master Jul 28, 2020
@Gimhan-minion Gimhan-minion deleted the alumni-section branch July 29, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piumal1999 Piumal1999 Piumal1999 approved these changes

@Gravewalker666 Gravewalker666 Gravewalker666 approved these changes

@anjula-sack anjula-sack Awaiting requested review from anjula-sack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing alumni section for past SEF members
4 participants
@Gimhan-minion @Piumal1999 @anjula-sack @Gravewalker666