Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IRC page with new profiles #767

Merged
merged 3 commits into from Sep 4, 2020
Merged

Conversation

janethavi
Copy link
Contributor

@janethavi janethavi commented Sep 2, 2020

Purpose

Add new IRC profiles.
The purpose of this PR is to fix #758

Goals

New research profiles are added.

Approach

Added the linked in profile pictures to the asserts.
Update the irc json file with new profiles

Screenshots

Screenshot from 2020-09-02 19-12-34

Preview Link

https://pr-767-sef-site.surge.sh/

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Test environment

-Ubuntu 18.04, Google Chrome

@akshika47
Copy link
Member

@janethavi you might want to get a better image of Ravihansa. His image has a sticker on it.

@janethavi
Copy link
Contributor Author

janethavi commented Sep 2, 2020

Screenshot from 2020-09-02 20-50-59
@akshika47 I Updated ravihansa's photo

@akshika47
Copy link
Member

Thank you @janethavi , Clearly, these issues are getting easier for you looking at the speed that you are completing them. I think it is time to level up. Check issues in the ScholarX repo (https://github.com/sef-global/scholarx/issues)! I think they might be of interest to you.

@Piumal1999
Copy link
Member

Thank you @janethavi !!!

@Piumal1999 Piumal1999 merged commit f1dce3d into sef-global:master Sep 4, 2020
@Piumal1999 Piumal1999 mentioned this pull request Oct 4, 2020
@janethavi janethavi deleted the irc branch November 25, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update IRC researchers list
3 participants