Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SEE LESS buttons to Scholarx,IRC and Team pages #958

Merged
merged 1 commit into from Jun 4, 2021
Merged

Add SEE LESS buttons to Scholarx,IRC and Team pages #958

merged 1 commit into from Jun 4, 2021

Conversation

gajindubandara
Copy link
Collaborator

@gajindubandara gajindubandara commented Jun 1, 2021 •
edited

Purpose

The purpose of this PR is to fix #957

Goals

To add "SEE LESS" buttons to Scholarx, IRC, and Team pages

Approach

Added "SEE LESS" buttons to Scholarx, IRC, and Team pages

Screenshots

Screenshot from 2021-06-01 10-19-34
Screenshot from 2021-06-01 10-19-40
Screenshot from 2021-06-01 10-19-51
Screenshot from 2021-06-01 10-20-01

Preview Link

https://pr-958-sef-site.surge.sh/

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

janethavi
janethavi approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@janethavi janethavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work @gajindubandara!

@Gimhan-minion Gimhan-minion merged commit 0c44f08 into sef-global:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janethavi janethavi janethavi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "SEE LESS" buttons to Scholarx,IRC and Team pages
3 participants
@gajindubandara @janethavi @Gimhan-minion