Merge pull request #1651 from Sefaria/clean_versions

feat: Remove version notes from translation selection sidebar. Keep …
Sefaria · Sep 21, 2023 · a91d5d0 · a91d5d0
2 parents 3fca137 + b8931f6
commit a91d5d0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/static/js/TranslationsBox.jsx b/static/js/TranslationsBox.jsx
@@ -89,6 +89,7 @@ class TranslationsBox extends Component {
                 openVersionInSidebar={this.openVersionInSidebar}
                 viewExtendedNotes={this.props.viewExtendedNotes}
                 inTranslationBox={true}
+                showNotes={false}
             />
           </>
       );

diff --git a/static/js/VersionBlock.jsx b/static/js/VersionBlock.jsx
@@ -171,6 +171,9 @@ class VersionBlock extends Component {
     }
   }
   makeVersionNotes(){
+    if (!this.props.showNotes) {
+      return null;
+    }
     if(Sefaria.interfaceLang=="english" && !!this.props.version.versionNotes){
       return this.props.version.versionNotes;
     }else if(Sefaria.interfaceLang=="hebrew" && !!this.props.version.versionNotesInHebrew){
@@ -459,6 +462,7 @@ class VersionsBlocksList extends Component{
                       viewExtendedNotes={this.props.viewExtendedNotes}
                       isCurrent={this.isVersionCurrent(v)}
                       inTranslationBox={this.props.inTranslationBox}
+                      showNotes={this.props.showNotes}
                     />
                   ))
                 }
@@ -480,6 +484,7 @@ VersionsBlocksList.propTypes={
   viewExtendedNotes: PropTypes.func,
   showLanguageHeaders: PropTypes.bool,
   inTranslationBox: PropTypes.bool,
+  showNotes: PropTypes.bool,
 };
 VersionsBlocksList.defaultProps = {
   displayCurrentVersions: true,