Skip to content

Commit

Permalink
Merge pull request #1616 from Sefaria/chart-info-completion
Browse files Browse the repository at this point in the history
helm(feat): add chart version to deployment message
  • Loading branch information
edamboritz committed Aug 30, 2023
2 parents 43866bf + 1b36197 commit eb8c7a1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ spec:
-X
POST
--data-urlencode
'payload={"channel": "#'$CHANNEL'", "username": "Deployment Status", "text": "'$ENV' revision '$REVISION' has deployed version '$VERSION'", "icon_emoji": ":globe_with_meridians:"}'
'payload={"channel": "#'$CHANNEL'", "username": "Deployment Status", "text": "'$ENV' revision '$REVISION' has deployed version '$VERSION' using chart '$CHART_VERSION'", "icon_emoji": ":globe_with_meridians:"}'
$SLACK_URL
||
/bin/true
Expand All @@ -39,6 +39,8 @@ spec:
value: "{{`{{args.deployment}}`}}" # {{`...`}}
- name: VERSION
value: "{{`{{args.version}}`}}" # {{`...`}}
- name: CHART_VERSION
value: "{{`{{args.chartVersion}}`}}"
- name: SLACK_URL
valueFrom:
secretKeyRef:
Expand Down
2 changes: 2 additions & 0 deletions helm-chart/sefaria-project/templates/rollout/web.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ spec:
value: {{ .Values.deployEnv }}
- name: version
value: {{ .Values.web.containerImage.tag }}
- name: chartVersion
value: {{ .Chart.Version }}
{{- end }}
selector:
matchLabels:
Expand Down

0 comments on commit eb8c7a1

Please sign in to comment.