Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like there is an error in RequestAuthenticator -> GetAuthenticationToken parameter order #6

Closed
phclem opened this issue Nov 1, 2017 · 1 comment

Comments

@phclem
Copy link

phclem commented Nov 1, 2017

    public AuthenticationToken GetAuthenticationToken(ApiRequest request)
    {
        var timestamp = (request.Timestamp).ToString(System.Globalization.CultureInfo.InvariantCulture);
        var signature = ComputeSignature(request);
        // the following construction has the parameters specified in an incorrect order
        // return new AuthenticationToken(_apiKey, signature, timestamp, _passphrase);
        // should be
        return new AuthenticationToken(_apiKey, _passphrase, signature, timestamp);
    }
@markwkjr
Copy link
Contributor

markwkjr commented Nov 20, 2017

@phclem I fixed this commit 284bba8c6f4efb2a3576659a346d52efbbe1cc0b. It has a bunch of other changes that I'm not sure are ready for a PR yet though :-/
It adds support for the PostOnly option in ordering, which I have tested and works. And then it has some unfinished code I was working on to support the Candles Endpoint

@sefbkn sefbkn closed this as completed Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants