-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Potential bug] Once PR title is modified kicking the tests again gets the old PR name #20
Comments
Hello @bastienboutonnet This is not expected but known issue. Unfortunately Github doesn't trigger any event after change of PR title. To overcome this, either pull request must be updated via push for example or close/open PR. There is a feature request (auto-close invalid PRs) #19 may cover this issue. |
Thanks for getting back to me on this. I'll keep an eye on when/if #19 will get implemented and see if the workflow is nice for the user but it doesn't sound like a bad one. Wish I could help but I don't really know much about scripting for these so it'll probably have to be left to someone who can really help. |
@bastienboutonnet this should fix it to some extend. When title is edited, it re-runs the job but adds new job alongside with failing status |
Ah nice, this may not be too shabby actually. I'm gonna give it a go! Thanks @seferov |
I'm not entirely sure if this is expected behaviour, but I tested the action with a PR that does not match the regex I had put and I get a fail (that is expected)
After editing the name of the PR in github and re runing the checks it looks like the action pulls the unmodified title (which was
Add pr lint action
but has been changed toFeature: Add pr lint action
The text was updated successfully, but these errors were encountered: