Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Potential bug] Once PR title is modified kicking the tests again gets the old PR name #20

Closed
bastienboutonnet opened this issue Nov 21, 2019 · 4 comments · Fixed by #21

Comments

@bastienboutonnet
Copy link

bastienboutonnet commented Nov 21, 2019

I'm not entirely sure if this is expected behaviour, but I tested the action with a PR that does not match the regex I had put and I get a fail (that is expected)

After editing the name of the PR in github and re runing the checks it looks like the action pulls the unmodified title (which was Add pr lint action but has been changed to Feature: Add pr lint action

title: Add pr lint action
##[error]Please fix your PR title to match ^Feature:|Fix:|Refactor:
##[error]Docker run failed with exit code 1
@bastienboutonnet bastienboutonnet changed the title Potential bug: Once PR title is modified kicking the tests again gets the old PR name [Potential bug] Once PR title is modified kicking the tests again gets the old PR name Nov 21, 2019
@seferov
Copy link
Owner

seferov commented Nov 22, 2019

Hello @bastienboutonnet

This is not expected but known issue. Unfortunately Github doesn't trigger any event after change of PR title. To overcome this, either pull request must be updated via push for example or close/open PR. There is a feature request (auto-close invalid PRs) #19 may cover this issue.

@bastienboutonnet
Copy link
Author

bastienboutonnet commented Nov 22, 2019

Thanks for getting back to me on this.
Yeah I figured it was probably a limitation from what was available to the action by github. Feel free to close this issue as there doesn't seem to be something we can do about it.

I'll keep an eye on when/if #19 will get implemented and see if the workflow is nice for the user but it doesn't sound like a bad one.

Wish I could help but I don't really know much about scripting for these so it'll probably have to be left to someone who can really help.

@seferov
Copy link
Owner

seferov commented Nov 23, 2019

@bastienboutonnet this should fix it to some extend. When title is edited, it re-runs the job but adds new job alongside with failing status

image

@bastienboutonnet
Copy link
Author

Ah nice, this may not be too shabby actually. I'm gonna give it a go! Thanks @seferov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants