Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with sse_channel #60

Open
milten21 opened this issue Sep 1, 2023 · 0 comments
Open

Issues with sse_channel #60

milten21 opened this issue Sep 1, 2023 · 0 comments

Comments

@milten21
Copy link

milten21 commented Sep 1, 2023

When using Server Sent Events transport there are at least 2 issues caused by underlying implementation of sse_channel

  1. When access token is used it is getting overriden along with any other query parameters causing 401 error. On signalr_client side this error is not handled properly and nothing happens until handshake timeout is triggered in HubConnection.
  2. There are no stop mechanism in sse_channel so when .stop() method is called on instance of HubConnection the underlying sse connection continues to exist and receiving server sent events leading to unwanted behavior.

If anyone encounters same issues I've made a workaround for them in here.

@sefidgaran I'd be glad to help resolving these if you can suggest a solution on how to deal with sse_channel. The package itself seems to be abandoned so I'm not sure if opening PR there would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant