Code parity with aspnetcore 3.1 typescript client, including auto-reconnect feature #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
March 12, 2020 16:55
markphillips100
changed the title
|
Had a chance to look at this PR @sefidgaran ? |
sefidgaran
reviewed
Nov 19, 2020
sefidgaran
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sefidgaran this PR aligns the code with the dotnet aspnetcore 3.1 typescript client along with support for auto-reconnect. I have included the (0.1.6 and 0.1.7) changes from 2 other PRs to make this (slightly) simpler. I believe these were already in your master branch.
In addition, I updated example code and readme to reference the signalr_netcore package name. Changelog and pubspec reflect a patch version bump however open to a minor change if it's necessary.
I've also run the chat and test examples on both android and ios emulators.
Let me know if you need anything, and thanks for considering the PR in the first place.