Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing BrowserClient #7

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Removing BrowserClient #7

merged 1 commit into from
Jun 29, 2021

Conversation

mikeesouth
Copy link

Removing BrowserClient because it breaks pub.dev compatibility checks for native applications (even though it works just fine with iOS / Android apps). The benefit of BrowserClient is that it supports http only cookies (response cookies) that are often used in SPA authentication scenarios. But the regular http client supports other types of authentication so this shouldn't be that big of a deal for most users.

…t breaks pub.dev compatibility checks for native applications
@sefidgaran
Copy link
Owner

sefidgaran commented Jun 29, 2021

Hi @mikeesouth,
Thanks for the PR.
About the https://pub.dev/packages/signalr_core package I gave it a try but it was not working in my case (I did not investigate to find out why) on that time so I used this package till now it is working perfectly.

@mikeesouth
Copy link
Author

Great, looks good on pub.dev now. I guess you can reply and close #5 too.
I'm still having the same issue with both this package and signalr_core, I've filed the issue here: jamiewest/signalr_core#58

I haven't received an answer but I think the error may come from the sse_client library so I'm going to investigate that soon. Both this package and signalr_core uses that library. SSE is only used by clients that does not support websockets and in my case that is iOS 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants