-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playlist api loader #25
Open
kphrx
wants to merge
12
commits into
segabito:master
Choose a base branch
from
kphrx:playlist-api-loader
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove UploadedVideoApiLoader that is no longer used
This reverts commit 69eff1e.
kphrx
force-pushed
the
playlist-api-loader
branch
from
August 9, 2022 11:15
8065585
to
ad25dc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
PlaylistApiLoader
を追加Changed
/api/mylist/list
,/api/mylistgroup/list
をnvapiの/v1/users/me/mylists
に置き換え/v1/users/me/watch-later
をplaylist apiに置き換えたが、既に存在したら頭に持ってくる処理でitemId
が存在せず削除に失敗するので実装し直しPlaylistApiLoader
で取得するように統一したので検索API互換の置き換えを削除簡易検索時に使われていたコンテンツ検索APIが終了したので暫定的にPlaylist APIを使用するように変更 // ここは素直にスナップショット検索APIを使うべき場面なので 69eff1e はrevert予定コンテンツ検索APIは replace contents search to snapshot search #26 でスナップショット検索APIに置き換えRemoved
UploadedVideoApiLoader
を削除