Allow using both fontAwesome5 and fontAwesome5Solid #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonPickup
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on Font.fontNames(forFamilyName:) to return an empty array to trigger loading a font (which assumes one font per fontFamily), check for presence of actual fontName.
However this broke the "Segoe MDL2" font because the font name in the code doesn't match the postscriptname in the .ttf file. Updated the code and renamed the ttf file to match.
Also an unrelated change (which I implemented trying to debug this) calls CTFontManagerRegisterFontsForURL() instead of CTFontManagerRegisterGraphicsFont() which follows Apple's recommendation, and simplifies the code. This is not necessary to fix the bug and can be removed if you wish.