Add username forwarding to target container

[segfly]

Implementation of #1

---

This change is

[segfly]

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

ssh-gitway/etc/entrypoint/forcecmd.sh, line 7 at r1 (raw file):

. /etc/entrypoint/rc

if [ "$FORCE_GIT_USER" -eq "1" ]; then

Forcing git user is supposed to be default, but will not be default with this logic.

---

Comments from Reviewable

[lynsei]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

ssh-gitway/etc/ssh.d/sshd_config, line 25 at r1 (raw file):

PasswordAuthentication no
AllowAgentForwarding yes
ForceCommand . /etc/entrypoint/rc && ${SSH_ORIGINAL_COMMAND:-cat /etc/motd} || ssh -q -t -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -p ${TARGET_SSH_PORT:-22} "git@${USER}" "${SSH_ORIGINAL_COMMAND}"

Certainly cleaner having it in the shell script. I wonder are we doing any sanitizing on USER or SSH_ORIGINAL_COMMAND... will have to look more through the code and see.

---

Comments from Reviewable

[segfly]

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

ssh-gitway/etc/entrypoint/forcecmd.sh, line 7 at r1 (raw file):

Previously, segfly (Nicholas Pace) wrote…

Forcing git user is supposed to be default, but will not be default with this logic.

Done.

---

Comments from Reviewable