Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Make search function "suggesting" #231

Closed
Wikinaut opened this issue Nov 13, 2017 · 6 comments
Closed

[Improvement] Make search function "suggesting" #231

Wikinaut opened this issue Nov 13, 2017 · 6 comments

Comments

@Wikinaut
Copy link
Contributor

Make search function suggests as you type (after entering 2 or 3 characters).

@Wikinaut
Copy link
Contributor Author

@segler-alex @werman can you? I really wish like to see this implemented.

@werman
Copy link
Contributor

werman commented Nov 13, 2017

@Wikinaut I definitely can implement this, but I don't have the time for it as for now. Anyway I can help if you are willing to implement it.

There is a lot to improve in the search like narrowing search by tags, bitrate, country, ... However quick suggestions will be a good start.

Some details I have thought of:

  • Results should be displayed even if one character is typed but from local station lists (to reduce requests amount).
  • When there is a small number of suggestions or query is like 3 - 4 characters long - make a search request.
  • Search request is forced if user presses a search button.
  • N last search results should be cached to reduce requests amount and improve responsiveness.

@Wikinaut
Copy link
Contributor Author

@Wikinaut
Copy link
Contributor Author

Wikinaut commented Dec 5, 2017

  • Soll ich mich hier ranwagen, oder kann es einer von Euch machen ?
  • Would prefer if someone of you can implement that in the near future.

@Wikinaut
Copy link
Contributor Author

Wikinaut commented Jan 11, 2018

ping

@Wikinaut Wikinaut changed the title [Improvement] Make station search function "suggests as you type" (after entering 2..3 characters) [Improvement] Make search function "suggesting" Feb 15, 2018
@Wikinaut
Copy link
Contributor Author

Wikinaut commented Feb 26, 2018

Updated and relaunched as a new issue #309.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants