Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Leak #306

Open
Robigus92 opened this issue Feb 23, 2018 · 2 comments
Open

Memory Leak #306

Robigus92 opened this issue Feb 23, 2018 · 2 comments

Comments

@Robigus92
Copy link

After a double rotation of the ActivityMain there are 2 instances more of:

class net.programmierecke.radiodroid2.ActivityMain @ 0x12d11000
class net.programmierecke.radiodroid2.FragmentTabs @ 0x12d1b800
class net.programmierecke.radiodroid2.FragmentPlayer @ 0x12d29800
class net.programmierecke.radiodroid2.FragmentCategories @ 0x12e75c00

It should not be like this because the rotations return to the same GUI state and the memory should stay in the same state as well.
@werman
Copy link
Contributor

werman commented Mar 2, 2018

Thank you finding the bug, I'll look into what happens there.

werman added a commit to werman/RadioDroid that referenced this issue Mar 31, 2018
@werman
fix memory leak of ActivityMain caused by MPDClient's thread. segler-…
2c0bb81 
…alex#306

The end solution should be a refactor of MPDClient.
Remove unnecessary creation of HistoryManager and FavouriteManager in ActivityMain.
segler-alex added a commit that referenced this issue Mar 31, 2018
@segler-alex
Merge pull request #316 from werman/bug/mainactivity-memory-leak
0ed46d7 
Fix memory leak of ActivityMain caused by MPDClient's thread. #306
@avently
Copy link
Contributor

avently commented Apr 7, 2018

Seems like it was fixed by wernan. Can you recheck?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@werman @avently @Robigus92