Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider changing to phantom-node #5

Closed
queckezz opened this issue Apr 7, 2014 · 2 comments
Closed

consider changing to phantom-node #5

queckezz opened this issue Apr 7, 2014 · 2 comments

Comments

@queckezz
Copy link
Contributor

queckezz commented Apr 7, 2014

There are some major problems with node-phantom:

The repository hasn't changed since 6 months ago and he hasn't replied to any of those issues. phantomjs-node is much more active and has the above issue fixed.

No need for those

this.page.setFn('EVIL_EVAL', ...)

hacks.
@reinpk
Copy link
Contributor

reinpk commented Apr 7, 2014

mmm great point, didn't do much diligence on it, but phantomjs-node does look healthier. would definitely accept a pr, otherwise i'll probably hack on it next weekend :D

reinpk pushed a commit that referenced this issue Apr 7, 2014
experimenting with phantomjs-node, for #5
a9459ad
@reinpk
Copy link
Contributor

reinpk commented Apr 8, 2014

good idea, thanks! just merged the change

@reinpk reinpk closed this as completed Apr 8, 2014
@sagistrauss sagistrauss mentioned this issue Mar 8, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reinpk @queckezz