New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call track async #18
Call track async #18
Conversation
}); | ||
} | ||
} | ||
|
||
- (void)reset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will presumably need it as well, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes good catch, will add
@VicV How does this look now with the requested changes? Thanks! |
Hey @ladanazita, it works well for me, but I'm waiting for @bbernberg to confirm this works sometime next week. |
@ladanazita looks like everything is working for the client. Good to go! 👍 Thanks for the quick response on this. Really appreciate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. DRY would be nice but not required atm.
Awesome. @ladanazita any idea when this will be in prod and good to go? |
@VicV I apologize for the delay, I was out of office yesterday. I can ship this today. |
@VicV this is on 1.1.2 now, thanks for the help! |
Fixes #17
All public API calls to the Taplytics SDK are dispatched synchronously:
This is causing deadlock issues with our analytics-ios SDK on key lifecycle events which must be handled synchronously. To resolve this, we will call the Taplytics SDK asynchronously.