Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Formatted Timestamp to Round-trip date/time pattern #30

Merged
merged 2 commits into from
Sep 17, 2015
Merged

Formatted Timestamp to Round-trip date/time pattern #30

merged 2 commits into from
Sep 17, 2015

Conversation

b-dur
Copy link
Contributor

@b-dur b-dur commented Sep 7, 2015

No description provided.

@b-dur
Copy link
Contributor Author

b-dur commented Sep 7, 2015

Fixes #29

@f2prateek
Copy link
Contributor

Thanks, should we be more explicit and use yyyy-MM-dd'T'HH:mm:ssZ? How often does the standard format change?

f2prateek added a commit that referenced this pull request Sep 17, 2015
Formatted Timestamp to Round-trip date/time pattern
@f2prateek f2prateek merged commit a50543d into segmentio:master Sep 17, 2015
@b-dur
Copy link
Contributor Author

b-dur commented Sep 18, 2015

Thanks for merging. According to msdn.microsoft the .ToString("o") is formatted to comply the ISO 8601.
And using .ToString("o") also matches the way the code is implemented if the timestamp is null.

Whether the timestamp should be converted into UTC time before sent from the client to the server depends whether the server can handle datetimes with timezones or not. Personally I prefer using UTC time everywhere.

@b-dur b-dur deleted the patch-1 branch September 18, 2015 06:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants