PE-88 Snap products - add product array support for Snapchat Conversions API #1557
Conversation
joe-ayoub-segment
changed the title
| let item_ids: string | undefined = undefined | ||
| let number_items: string | undefined = undefined | ||
| let item_category: string | undefined = undefined | ||
| let price: string | undefined = undefined | ||
| let brands: string[] | undefined = undefined |
There was a problem hiding this comment.
This should have the same impact of the current code but a bit more simple. Specifically removing the need for manual type specification and later nullish coalescing. All of these items would still be replaced if payload?.products is an array with non-zero length.
| let item_ids: string | undefined = undefined | |
| let number_items: string | undefined = undefined | |
| let item_category: string | undefined = undefined | |
| let price: string | undefined = undefined | |
| let brands: string[] | undefined = undefined | |
| let item_ids = payload?. item_ids | |
| let number_items = payload?. number_items | |
| let item_category = payload?.item_category | |
| let price = payload?.price | |
| let brands = payload?.brands |
packages/destination-actions/src/destinations/snap-conversions-api/snap-capi-properties.ts
Show resolved
Hide resolved
| number_items: number_items ?? payload?.number_items, | ||
| price: price ?? payload?.price, |
There was a problem hiding this comment.
Continuation of lines 438-442 suggestion.
| number_items: number_items ?? payload?.number_items, | |
| price: price ?? payload?.price, | |
| number_items, | |
| price, |
| @@ -331,6 +406,18 @@ export const hash = (value: string | undefined): string | undefined => { | |||
|
|
|||
| const isHashedEmail = (email: string): boolean => new RegExp(/[0-9abcdef]{64}/gi).test(email) | |||
|
|
|||
| // eslint-disable-next-line | |||
| const transformProperty = (property: string, items: Array<any>): string => | |||
There was a problem hiding this comment.
Should be able to do items: Array<Record<string, string | number | undefined>> to avoid disabling the eslint rule.
packages/destination-actions/src/destinations/snap-conversions-api/snap-capi-properties.ts
Show resolved
Hide resolved
packages/destination-actions/src/destinations/snap-conversions-api/snap-capi-properties.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/snap-conversions-api/_tests_/index.test.ts
Outdated
Show resolved
Hide resolved
|
@joe-ayoub-segment given that none of the comments above are logical issues we can handle them in another PR so we don't block the customer if desired. Let me know what you think. |
Thanks @dcasey-sc , let's go ahead with the PR then, thanks for verifying everything!! |
|
Testing after adding new field allow price calculation to be toggled TEST 1: calculates price from product array details. |
|
TEST 2: takes price from "Price" field |
|
TEST 3: excluding product array falls back to using individual fields |
Updating mappings for Price field to match Segment Spec
|
Hi @dcasey-sc this PR has been deployed! |
…ons API (segmentio#1557) * adding snap product array support * test and fix type * more changes * fixing test * minor changes post testing * minor changes * minor changes * type description changes * addressing linting issue * minor recommended changes * adding options for how to track purchase price * label changes * making function more strongly typed * adding tests * Updating mappings for Price field Updating mappings for Price field to match Segment Spec * changing price and number_items * removing files which were added by accident
Update the Snapchat Conversions API Destination so that it can handle a Segment products array.
Specifically a new array field added to support this type of structure:
"products": {
{"product_id": "12345", "price": 100, "category": "toys", "brand": "Hasbro", "quantity": 5},
{"product_id": "98765", "price": 76, "category": "games", "brand": "Mattel", "quantity": 2},
}
Testing
Tested using the Actions Tester connected to Snapchat. Test results here.
Unit test added to test that arrays of products are accepted.