Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TikTok Pixel Destination #1937

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Update TikTok Pixel Destination #1937

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9376af1
add all presets for pixel sdk & update event properties support
Mar 18, 2024
285cee3
update default values & global settings
Mar 19, 2024
cb531d1
use existing pixel setting
jae-rhee-tiktok Mar 27, 2024
fd5ed26
revert pixel init script
jae-rhee-tiktok Mar 27, 2024
a26ffe2
update
jae-rhee-tiktok Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions packages/browser-destinations/destinations/tiktok-pixel/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,18 +220,15 @@ export const destination: BrowserDestinationDefinition<Settings, TikTokPixel> =
},
useExistingPixel: {
// TODO: HOW TO DELETE (reusing will not include Segment Partner name)
label: 'Use Existing Pixel',
label: '[Deprecated]Use Existing Pixel',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
label: '[Deprecated]Use Existing Pixel',
label: '[Deprecated] Use Existing Pixel',

type: 'boolean',
default: false,
description:
'Important! Changing this setting may block data collection to Segment if not done correctly. Select "true" to use an existing TikTok Pixel which is already installed on your website. The Pixel MUST be installed on your website when this is set to "true" or all data collection to Segment may fail.'
required: false,
description: 'Deprecated. Please do not provide any value.'
}
jae-rhee-tiktok marked this conversation as resolved.
Show resolved Hide resolved
},
initialize: async ({ settings }, deps) => {
if (!settings.useExistingPixel) {
initScript(settings)
}

initScript(settings)
jae-rhee-tiktok marked this conversation as resolved.
Show resolved Hide resolved
await deps.resolveWhen(() => window.ttq != null, 100)
return window.ttq
},
Expand Down