Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option mapping field for messageId in segment profiles #1942

Merged
merged 11 commits into from
Apr 23, 2024

Conversation

hvardhan-unth
Copy link
Contributor

@hvardhan-unth hvardhan-unth commented Mar 20, 2024

Added support for optionally mapping messageId in all actions in the Segment profiles destination.
JIRA Ticket:- https://segment.atlassian.net/browse/STRATCONN-3665

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • [Segmenters] Tested in the staging environment

Testing document for staging:-
https://docs.google.com/document/d/15rwDvOodcSq9SwFD5p-NvCZYsi3dBAnFBCMlB3_YshQ/edit?usp=sharing

@varadarajan-tw varadarajan-tw self-requested a review April 16, 2024 08:09
Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good but there are some tests failing. Could you pls fix those?

@hvardhan-unth hvardhan-unth requested a review from a team as a code owner April 16, 2024 08:34
@joe-ayoub-segment joe-ayoub-segment self-assigned this Apr 16, 2024
@hvardhan-unth hvardhan-unth merged commit db71edd into main Apr 23, 2024
11 checks passed
@hvardhan-unth hvardhan-unth deleted the STRATCONN-3665-Segment-Profiles branch April 23, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants