Update user_hash mapping #1957
Merged
Update user_hash mapping #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated context.Intercom.user_hash to integrations.Intercom.user_hash
joe-ayoub-segment
approved these changes
Apr 22, 2024
joe-ayoub-segment
deleted the
intercom-web-actions-user-hash-mapping-correction
branch
|
hi @bcaudillo this PR has been deployed. Please confirm that you are happy with the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently our out of the box mapping to user_hash is incorrect. It reads context.Intercom.user_hash when it should be integrations.Intercom._user_hash.
Is it a bug/defect?
Yes
Is it reproducible?
Yes, go to Intercom Web (Actions) and select the Identify User mapping. Scroll down to User Hash and test a payload where the Integrations object looks like:
"integrations": { "Intercom": { "user_hash": "75ae885f908a8a25f2c88a3ba2f1a40892b0aab7515aa66f6c6e0eea0bdcc861" } },Check your mapping and see this value does not populate with the out of the box mapping.
Workaround available?
Yes, we are currently asking users to modify their mapping manually.
Expected Behavior:
Out of the box mapping should work as Intercom expects to receive this value.
Actual Behavior:
This value does not populate unless our mapping is modified.
Relevant Slack Thread
https://twilio.slack.com/archives/C9Z93GW76/p1711388844654799?thread_ts=1711386641.613429&cid=C9Z93GW76