feat(screeb): identify on init #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,7 +72,12 @@ export const destination: BrowserDestinationDefinition<Settings, Screeb> = { | |||
| await deps.loadScript('https://t.screeb.app/tag.js') | |||
| await deps.resolveWhen(() => window.$screeb !== preloadFunction, 500) | |||
|
|
|||
| window.$screeb('init', settings.websiteId) | |||
| let visitorId: ID = null | |||
There was a problem hiding this comment.
hi @samber - not sure if the ID type needs to be imported.
Can you just do this please?
let visitorId: string | null | undefined = null
joe-ayoub-segment
approved these changes
Apr 22, 2024
|
Hi @samber - this PR has been deployed. Please confirm that it looks correct to you! |
|
@joe-ayoub-segment i just tested and it works very well, thanks ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Screeb, we need to identify users when the tag is initialized. If we do it later, then the tag will create an identify for a short period (between
init()andidentify()). Customers are disappointed by this behavior, so we inject the segment userId.AnonymousId is ignored since Screeb does not have such a concept.